Folks, any feedback on 2.17.0rc3? If not, I'd like...
# developmenth
happy-kitchen-89482
08/19/2023, 9:45 PMFolks, any feedback on 2.17.0rc3? If not, I'd like to promote it to 2.17.0 early next week!
b
bitter-ability-32190
08/20/2023, 1:40 AMSo far so good with my testing at $work
f
fast-nail-55400
08/20/2023, 8:13 AMAny updates needed for the What’s New section of release notes?
r
rhythmic-morning-87313
08/20/2023, 3:04 PMWould it be compatible with 2.16-based plugins like my platform-specific dependency injector? Whenever I follow the pants major update, I had to re-adapt the plugin codes...
h
happy-kitchen-89482
08/20/2023, 9:38 PMProbably, yes, 2.17 was not a huge release. But the only way to know is to try...
👀 1
b
broad-processor-92400
08/21/2023, 12:27 AMI've made some updates to What's New https://github.com/pantsbuild/pants/pull/19629
I suspect there might be some changes in 2.17.0rc0 and after that are worth calling out too (e.g. especially the user/plugin API changes) since I think that's after the what's new draft was written. I don't have a chance to look over that now, but I might do later today
broad-processor-92400
08/21/2023, 8:07 AMrc3 seems to work fine on my internal codebase... but https://github.com/pantsbuild/pants/pull/19630 for https://github.com/pantsbuild/pants/issues/19618 might be important? Or maybe the work around of
use_rust_parser = falsebroad-processor-92400
08/22/2023, 2:55 AMhttps://github.com/pantsbuild/pants/pull/19640 gets that fix into 2.17, since it seems like we might need to be slotting in another change anyway.
b
bitter-ability-32190
08/22/2023, 11:22 AMYeah I'd like to get the mypy fix in as well
h
happy-kitchen-89482
08/22/2023, 2:00 PMOK, please ping me when everything you want in 2.17 is in, and we can cut another rc
b
broad-processor-92400
08/23/2023, 7:16 AMI think what's remaining is:
• https://github.com/pantsbuild/pants/pull/19655 : test flakiness, I'll keep retrying, but it might get to my bed time before it passes 😅
• https://github.com/pantsbuild/pants/pull/19188 : doesn't seem like a flaky test, but I couldn't reproduce locally
broad-processor-92400
08/23/2023, 7:53 PMOkay, I think that is everything now, with the decision to not pick 19188 from https://pantsbuild.slack.com/archives/C0D7TNJHL/p1692816683394949?thread_ts=1692528451.518099&channel=C0D7TNJHL&message_ts=1692816683.394949
h
happy-kitchen-89482
08/23/2023, 9:12 PMCool, so I'll cut one more 2.17 RC now?
👍 1
b
bitter-ability-32190
08/23/2023, 9:12 PMFingers crossed the release automation doesn't trip on itself 🤞
b
broad-processor-92400
08/23/2023, 10:48 PMFine by me... although I just noticed https://github.com/pantsbuild/pants/pull/19659 was posted, if you hvaen't started the process yet (always things at the last minute 😅 )
3 Views