One of the topics that came up twice today in diff...
# development
f
One of the topics that came up twice today in different contexts was potentially using the changed subsystem on Pants CI instead of
pants test ::
. Is this something that multiple people want? I would definitely be for this as I see it as dogfooding a really useful feature. I'd gladly make an issue about this and work on pushing it if there's interest. @wide-midnight-78598 you mentioned this too.
w
I can’t think of a good reason to not use
changed
and
transitive
for lint, test, fix, whatever else on CI. Either it works perfectly, and our CI time is reduced by some non-zero amount, or it doesn’t work correctly which flags a problem that needs to be fixed. As Benjy has mentioned, a lot of our CI flakiness and time is spent in integration tests, so
changed
won’t help there, but that’s not a reason to avoid `change`d
If we’re worried about missing something, then maybe a nightly full CI run to capture potential problems? But, otherwise. I think it’s also worth taking a look into whether some of our integration CI tests can be degraded into one of the other types of unit tests instead, which could generate some big wins
c
We can also immediately run a full ci run on the main branch on the squashed commit. So it's not blocking but also we can know pretty quickly
f
I know there’s a few things that don’t work using changed. For example changing tool configs should cause all checks of that type to be run again but don’t get picked up because they’re not part of the dep graph