I was surprised that I can't merge my `scie-pants`...
# developmentb
bitter-ability-32190
07/20/2023, 12:02 PMI was surprised that I can't merge my
scie-pantsbitter-ability-32190
07/20/2023, 12:04 PMI'm also not sure I can sign commits without re-writing history and I HATE force-pushing/rewriting history because it destroys context.
š¢
h
hundreds-father-404
07/20/2023, 1:34 PMI don't think John is in this channel anymore, so he won't see this message. Could you recreate the PR?
b
bitter-ability-32190
07/20/2023, 2:52 PMI think that has the same result of not bring genuine with the changes history.
But I don't think we need John's approval. I think we should be consistent across all Pantsbuild repos. Additionally John has left that repo to us. https://github.com/pantsbuild/scie-pants/pull/226#issuecomment-1642818117
bitter-ability-32190
07/20/2023, 2:53 PMI propose we turn this off and maybe we can discuss it more openly and come to a public agreement. Otherwise I'm kinda stuck for now.
š 2
h
happy-kitchen-89482
07/20/2023, 4:13 PMIf we turn it back on later hopefully it doesn't apply retroactively?
b
bitter-ability-32190
07/20/2023, 4:13 PMI don't understand the question š
Like you're worried about it not allowing us to turn it on later because there's unsigned commits?
š 1
bitter-ability-32190
07/20/2023, 4:14 PM(I also don't understand the error, because presumably I wouldn't have signed the squash-merge commit thats merged to
mainbitter-ability-32190
07/20/2023, 4:44 PMI just enabled the setting on a personal repo with unsigned commits. I haven't caught fire, and neither has my repo.
bitter-ability-32190
07/20/2023, 4:45 PM(I'm still perplexed how GitHub could require the squash commit be signed by my key š„“ Maybe it uses its own key after seeing my commits were me?)
E.g. "trust me, I trust them"
bitter-ability-32190
07/20/2023, 4:48 PMb
broad-processor-92400
07/20/2023, 11:40 PMThat PR is quite small, so I'd suggest rewriting history is perfectly fine, and not worth blocking merging the PR on resolving a policy question.
We're squash-and-merge-ing, so, if someone wants more info, it's not just surfaced in a plain
git blame ...b
bitter-ability-32190
07/21/2023, 1:20 AMOK I'm going to turn it off for this repo.
If we decide we want it on, we:
ā¢ should discuss this more thoroughly with more maintainers in the room with a list of the pros/cons
ā¢ be consistent across all pantsbuild repos (where it makes sense)
h
happy-kitchen-89482
07/21/2023, 6:17 PMAre there cons to signing commits?
happy-kitchen-89482
07/21/2023, 6:18 PMOther than the extra hassle of setting it up?
b
bitter-ability-32190
07/21/2023, 6:19 PMI think that hassle is a barrier to entry.
And if someone hadn't signed commits, they have to destroy the history in their PR to do so š
For every PR we had from new folks in the last 3 months how many were verified?
What about other popular open source repos?