Looks like after `2.18.0.dev0` (and beofre `dev1` ...
# development
b
Looks like after
2.18.0.dev0
(and beofre
dev1
) the wheel builds are versioned with a timestamp, which isn't stripped. I think this'll make
scie-pants
fail to find the wheel builds using the link for the SHA See https://binaries.pantsbuild.org/?prefix=wheels/pantsbuild.pants/46b95
CC @broad-processor-92400 I think https://github.com/pantsbuild/pants/pull/19179 is the change
FWIW this point might be moot if we bump scie-pants to use local PEXs ona release, or even wheels uploaded to a release as the find-links. But those require scie-pants changes (and therefore upgrades) so we might wanna fix this and re-upload to s3 without the timestamp?
(Also CC @happy-kitchen-89482 and @witty-crayon-22786)
b
What symptoms would you expect from this problem? I can install/run 2.18.0.devX releases using scie-pants
b
I think if you disabled PyPI you'd likely feel the pain? (Or in the future if we yanked the release)
Alternatively, try
PANTS_SHA
with a ref of one of the dev release SHAs
b
Okay, yes, that reproduces the problem.
Copy code
# 2.18.0.dev0: works
PANTS_SHA=a9e570fb1cae4e10ebfb9039f163841e59236f73 pants test ::

# 2.18.0.dev1: fails
PANTS_SHA=46b95186f0ea5188cecb522b348664b855151270 pants test ::
I feel
PANTS_SHA
is a bit weird, now that we're not building wheels for every build, and the only things that can be run are releases either specifying
PANTS_VERSION=...
or manually digging up the sha to use
PANTS_SHA
. So, options I can think of: either of which seem fine by me: 1. Revert #19179 (leaving the affected 2.18.0.devX releases as they are seems fine) and don't even bother reopening the underlying issue 2. Deprecate support for
PANTS_SHA
from scie-pants, in favour of just
PANTS_VERSION
(NB. this will affect people using older versions, e.g. if someone is stuck on using some random commit between 2.13.0 and 2.14.0) 3. Something else?
b
FWIW I plan on proposing 2, although not deprecating it as in remove the code. Just deprecating as in "won't work after X".