bitter-ability-32190
07/18/2023, 8:32 PM2.18.0.dev0
(and beofre dev1
) the wheel builds are versioned with a timestamp, which isn't stripped.
I think this'll make scie-pants
fail to find the wheel builds using the link for the SHA
See https://binaries.pantsbuild.org/?prefix=wheels/pantsbuild.pants/46b95bitter-ability-32190
07/18/2023, 8:33 PMbitter-ability-32190
07/18/2023, 8:34 PMbitter-ability-32190
07/18/2023, 8:44 PMbitter-ability-32190
07/18/2023, 8:44 PMbroad-processor-92400
07/18/2023, 10:15 PMbitter-ability-32190
07/18/2023, 11:49 PMbitter-ability-32190
07/18/2023, 11:50 PMPANTS_SHA
with a ref of one of the dev release SHAsbroad-processor-92400
07/19/2023, 12:49 AM# 2.18.0.dev0: works
PANTS_SHA=a9e570fb1cae4e10ebfb9039f163841e59236f73 pants test ::
# 2.18.0.dev1: fails
PANTS_SHA=46b95186f0ea5188cecb522b348664b855151270 pants test ::
I feel PANTS_SHA
is a bit weird, now that we're not building wheels for every build, and the only things that can be run are releases either specifying PANTS_VERSION=...
or manually digging up the sha to use PANTS_SHA
.
So, options I can think of: either of which seem fine by me:
1. Revert #19179 (leaving the affected 2.18.0.devX releases as they are seems fine) and don't even bother reopening the underlying issue
2. Deprecate support for PANTS_SHA
from scie-pants, in favour of just PANTS_VERSION
(NB. this will affect people using older versions, e.g. if someone is stuck on using some random commit between 2.13.0 and 2.14.0)
3. Something else?bitter-ability-32190
07/19/2023, 1:11 AM