Was taking a look at <this> yesterday out of curio...
# development
n
Was taking a look at this yesterday out of curiosity - can make a PR to support passing the
--network
option to docker build if that would be welcomed? @curved-television-6568?
c
Yea, we need to do something about this. Preferably it would cover all docker build options and not just a few of them.
n
There are a few... Would you prefer a way to pass an arbitrary string of options, eg.
--network host --force-rm --add-host host:1.2.3.4
, or map all the build options to pants docker options? I don't think it's a big lift to do the latter - was thinking of just starting with one and then doing follow up for the others.
👍 1
c
I guess the options don’t change that frequently so simply adding them one by one could be ok, if you’re willing to do that. If it were me, I’d like to find a generic way to accept arbitrary flags I think.. if I could make the UX for it feel OK. Haven’t thought about how to implement this so 🤷
n
Arbitrary CLI opts might make it harder to switch to the docker API later though, if that's planned
👍 1
c
I think we may want to switch to the rust docker crate we use for docker_environment also for docker_image etc, so yea, that may make that easier, perhaps.
n
Created an issue here - I haven't looked into the rust side of things though
👍 1