https://pantsbuild.org/ logo
Join Slack
Powered by
I noticed that in 2.16 help there is a weird forma...
# development
f
I noticed that in 2.16 help there is a weird formatting issue where readme.com markdown formatter thinks that 
{doc_url('targets')}
drawn as a URL should be converted to an emoji of sun (
Sun (Light Mode)
)? It seems ubiquitous in the help system; search for "sun" on the web site
☀️ 2
image.png
has anyone worked on the help generation recently and has more context?
I've logged in into the readme.com to see if there's anything there, but it's just plain markdown there with 
Sun (Light Mode)
text already, so it must have been rendered this at the upload time
h
Yikes! That is bad
Good find
Can you open an issue?
Is it just 
doc_url('targets')
as far as you can tell, or are there other references that turn into emoji?
f
Created https://github.com/pantsbuild/pants/issues/19309.
Is it just 
doc_url('targets')
as far as you can tell, or are there other references that turn into emoji?
it seems it's anything that has 
doc_url()
in in, no matter the input
b
I'm gonna guess ReadMe added support for a newer set of unicode emojis, and something that previously didn't map to an emoji does now 😅
f
But my understanding is that the f strings are rendered to markdown first when someone prepares the data to be uploaded, no?
b
Right, but if the Readme-flavored markdown supports emojicode, it might be we were rending the string 
:sun:
which meant literally that string, but then they added the ☀️ emoji which maps to 
:sun:
(as an example)
(Or similarly 
:(
, which some places map to 😢 )
f
Yes I totally get it and it makes perfect sense. We render the URL, so it's Https:// something
So I just can't see how can this URL be turned into an emoji
b
Ahh, figured it out (mostly). So 1: it isn't emojicode. We really are rewriting the Markdown to use 
Sun (Light Mode)
Secondly, this comes from URL rewriting when we publish the markdown, we turn URLs to doc references. Part of that is grabbing the title of the URL page. Turns out we're grabbing the little light/dark toggle sun as the title 😂
Parsing HTML is finicky 😛
OK assigned myself to the issue (and commented there)
f
brilliant, thank you
b
Open in Slack
PreviousNext
Powered by