So just tried out `2 16 0rc6` in CI and we hit the same AWS Pants #development

So just tried out `2.16.0rc6` in CI, and we hit th...

bitter-ability-32190

06/09/2023, 3:45 PM

So just tried out

2.16.0rc6

in CI, and we hit the same AWS token issue. Primarily because

botocore

apparently is inconsistent with casing of headers. 😠 I fixed the upstream PR to

botocore

, and I'll open a PR to Pants (which I'm going to bang on more thoroughly locally first) At this point is it even worth CPing to 2.16.x? People can copy the plugin locally as an in-repo plugin...

bitter-ability-32190

06/09/2023, 3:46 PM

CC @happy-kitchen-89482 and @broad-processor-92400.

bitter-ability-32190

06/09/2023, 3:46 PM

We could do a quick turnaround for 2.16.1

👍 1

curved-television-6568

06/09/2023, 4:42 PM

my vote for “niche” bugs like this is to hold for the next patch release. 😉

👍 1

curved-television-6568

06/09/2023, 4:49 PM

Primarily because
botocore
apparently is inconsistent with casing of headers. 😠

that was one half of my comment on your botocore PR.. I just didn’t spell it out (and didn’t notice that they were using it inconsistently) only that your change didn’t align with the next line..

happy-kitchen-89482

06/09/2023, 7:29 PM

Yeah, we really need to get 2.16.x out...

bitter-ability-32190

06/09/2023, 7:38 PM

I have a bugfix now I know works, but I won't be butthurt if it doesn't get into .0. the workaround is well known, and this feature is more niche

bitter-ability-32190

06/09/2023, 7:39 PM

I'm testing 2.16.x on CI today and Tuesday (I'm out Monday)

happy-kitchen-89482

06/09/2023, 8:14 PM

Well, now to Tuesday is NBD

happy-kitchen-89482

06/09/2023, 8:15 PM

we can do a last rc on Tuesday, give it 24 hours for you to test, then declare it stable

bitter-ability-32190

06/09/2023, 9:07 PM

OK no need to wait. CI has completed

lint check test

, and there's only one test failure (relating to some behavior with the new resolve-for-tools. I'll write it up if I consider it a bug, or just a quirk)

happy-kitchen-89482

06/10/2023, 12:03 AM

To clarify, you're saying that another rc could be done today?

happy-kitchen-89482

06/10/2023, 12:03 AM

i.e., you don't need tuesday for testing?

bitter-ability-32190

06/10/2023, 12:09 AM

Do we need another rc? rc6 works for everything but the S3 bug that didn't get fixed

happy-kitchen-89482

06/10/2023, 12:47 AM

Yes, but you wanted to get that fix in to 2.16.0? I'm saying I can bang out another RC on Tuesday if that is helpful.

happy-kitchen-89482

06/10/2023, 12:49 AM

Or on Monday, or over the weekend.

bitter-ability-32190

06/10/2023, 1:05 AM

It's up to you. That fix will make it into either 2.16.0 or 2.16.1. obviously .0 is preferred, but I don't think it's a showstopping bug

Open in Slack

Previous Next