https://pantsbuild.org/ logo
Join Slack
Powered by
Based on <https://github.com/pantsbuild/pants/pull...
# development
b
Based on https://github.com/pantsbuild/pants/pull/19249 Should we rename "bugfix" category to something like "user bugfix" or "postrelease bugfix"?
@curved-television-6568 @happy-kitchen-89482
h
Eh
Maybe
In #19249 everything went well, @curved-television-6568 and I just got confused in the release, but we should have trusted the label.
So really the problem wasn't the label (which was correct) but PEBKAC
b
Yeah this happened to me with a PR once which is why I had it mind with your comment. It's easy enough to change, and makes the intent much clearer, which hopefully makes sure this doesn't happen again
h
That's my concern, I don't think it will - the issue here was with knowing whether this was a pre- or post-release bugfix.
I.e., I already knew that a pre-release bugfix should be 
internal
, I just misunderstood what this was
I should have trusted the PR author's tagging
There's no harm in renaming, sure
But will it solve the issue...
b
Ah well it'll solve An issues just not that one then
@curved-television-6568 were you confused?
c
Yea, no point in renaming the bugfix label. My suggested future action is to call out when an internal PR fixes a bug was also left on the PR in question as a comment.
b
Actually.. couldn't we enforce this? You shouldn't be able to label something internal and have a cherry-pick to a milestone with a release
c
Ah, maybe a “pre-release-bug” could signal the same…
But I don’t really wish for more labels
b
I wouldn't trust my tagging... 🤡 But actually, I'm not entirely sure of the conventions. I translated this conversation into descriptions on the labels: feel free to update!
👍 1
b
Bueno
Open in Slack
PreviousNext
Powered by