Almost done with the second modern-ification of th...
# developmentb
bitter-ability-32190
06/01/2023, 3:39 PMAlmost done with the second modern-ification of the cherry pick automation. one thing I've realized is that testing this thing SUCKS. With a decent amount of hand-holding, One can use
actpants --no-pantsd run build-support/bin/cherry_pick_one.js -- <arg1> <arg2>w
witty-crayon-22786
06/01/2023, 4:47 PMJS wouldn’t be my first choice (given that we already have a lot of Python common code), but i don’t feel strongly about it
b
bitter-ability-32190
06/01/2023, 4:48 PMAh maybe I should also clarify why I prefer JS: https://github.com/actions/github-script
w
witty-crayon-22786
06/01/2023, 4:49 PMhm. that doesn’t look very maintained… would probably be safer to stick to the core API?
b
bitter-ability-32190
06/01/2023, 4:51 PMI don't think it isn't?
https://github.com/actions/github-script/commits/main shows recent activity.
Also,
Used by 101k
w
witty-crayon-22786
06/01/2023, 5:00 PMit also doesn’t look like these scripts are testable/lintable, since they are a function fragment
b
bitter-ability-32190
06/01/2023, 5:00 PMw
witty-crayon-22786
06/01/2023, 5:04 PMi remain skeptical, but i won’t block.
witty-crayon-22786
06/01/2023, 5:05 PMavoiding bash is good though.
b
bitter-ability-32190
06/01/2023, 5:05 PMI can speak from current experience, this is very convenient
p
proud-dentist-22844
06/01/2023, 5:50 PMThere's also https://ghapi.fast.ai/ and https://github.com/graphql-python/gql which could be used to do something similar in python.
That said, JS seems to be the lingua-franca of GHA, so using it for this makes sense.
b
bitter-ability-32190
06/01/2023, 5:51 PMI'm hoping to avoid a Python script with dependencies 😅 DOn't wanna go through that cluster in CI 😛
bitter-ability-32190
06/01/2023, 6:00 PMOK I think I've boiled this down to two scripts:
1. One script for gathering the relevant milestones. The key thing is this needs to output JSON, Bash is not our friend here...
◦ But this is only relevant in CI
2. One script for making a PR given an already-existing branch. This is the one people might be running
◦ The key here is mostly copying the title, reviewers, etc... from the original PR
I'm actually thinking of just making 2 a bash script. We can hand the user the arguments, and
ghp
proud-dentist-22844
06/01/2023, 6:03 PMJSON and Bash have been at war! The impedance mismatch between structured stdout vs line-based string stdout is often problematic.