https://pantsbuild.org/ logo
Join Slack
Powered by
I'm doing some refactoring of the `system_binaries...
# development
b
I'm doing some refactoring of the 
system_binaries
rules. This gives me an opportunity to fix https://github.com/pantsbuild/pants/issues/18669 by using Python stdlib. So, please jump in on that issue if you have thoughts...
w
Is 
system_binaries
consumed by adhoc tool, or does adhoc tool use a different mechanism to pick up?
b
Specifically, the issue is about switching the 
tar
and 
zip
rules to use Python stdlib for determinism instead of/on top of the system binaries
f
Is the stdlib being used in a script invoked from a 
Process
?
Because with remote execution, you would otherwise have to bring a large blob to the local executor.
And better to do operation on large archives in the remote execution environment.
➕ 1
b
Yes. Which we know is always guaranteed to exist, thanks to our own Bootstrapped Python. But you have a point that bringing along a Bootstrapped Python might be painful
Let's discuss on Issue? 🙂 That's good point(s) that should be preserved for posterity
👍 1
f
You linked an issue not a PR ...
b
Oops, thats what I meant
👍 1
a
@wide-midnight-78598 
adhoc_tool
itself does not use 
system_binaries
per se (it does depend on Bash at the moment). 
system_binary
(the target) uses its own implementation because the error handling (in 
system_binaries
) is a bit narrow
w
Aha, okay, - I had a bug to report (or, maybe just a documentation thing), which I believe I forgot. If it overlapped with something we already were working on, then even better.
2 Views
Open in Slack
PreviousNext
Powered by