What's the deal with <https://www.pantsbuild.org/v...
# development
b
What's the deal with https://www.pantsbuild.org/v2.16/docs/reference-subprocess-environment#env_vars? It seems like it's only used in Python, but the name sounds generic?
h
it comes from Pants 1.25 before we had any best practices etc https://github.com/pantsbuild/pants/issues/14809
b
Oh wow! Code Archeology
h
hah yeah I wish we fixed it as part of 2.0. At the very beginning, when it was added, it was basically adding whatever it took to get Twitter and Pants using remote execution for the
test
goal (my project). Before that, v2 was I think only used for
list
. So we used a lot of hacks
h
Yeah, probably it should be used everywhere? It's often used for generic things like LC_CTYPE and LANG
b
I'm trying to use
PATH
and
LD_LIBRARY_PATH
So yeah, very generic
h
So it should probably be used as described on the tin! I'd consider it a bug that it is not
1
w
Yeah, probably it should be used everywhere? It’s often used for generic things like LC_CTYPE and LANG
while a subsystem for “evironment variables which are used absolutely everywhere” would probably be useful, i don’t think that
PATH
and
LD_LIBRARY_PATH
are likely candidates for that subsystem (whereas LC_CTYPE and LANG probably are). a proliferation of purpose-driven / “scoped” subsystems makes more sense to me, although “path-like” variables are strange, because they are almost always additive.
👍 1