https://pantsbuild.org/ logo
Join Slack
Powered by
hey folks: i’m on release duty today. i’ll execute...
# development
w
hey folks: i’m on release duty today. i’ll execute any `rc`s / finals i can from 
2.14.x
and 
2.15.x
once the ARM shard is healthy again. but i’m going to hold off on 
2.16.x
and 
2.17.x
releases, since Benjy did/is-doing them in the last few days. i’ll aim to do a 
2.16.0
final early next week, and cut the 
2.17.x
branch at the same time
🎉 2
💗 2
p
can https://github.com/pantsbuild/pants/pull/18790 be cherry-picket into 2.16 ?
or is it to late in the stabilization phase?
w
we generally shouldn’t cherry-pick features, and 2.16.x is quite late at this point
👍 1
is it blocking something?
p
upgrading docformatter to 1.6
w
is that blocking something?
are older versions broken in some way?
p
no
f
thanks a lot, @witty-crayon-22786! I can't wait to upgrade to 2.16 and start using the visibility feature in house!
w
if you have bug fixes bound for 2.16.x, please get them in asap: I'd definitely like to get it cut midweek if possible
🙏 1
b
Today I'm hoping to do more upgrade-to-Pants-2.16 work at $work, so hold youre breath 🙂
f
yes, will do the same for some exploratory testing to find any issues before we can cut 2.16.0!
h
I have a blocker for 2.16.x in the works
👍 1
Should have it out today
mostly testing now
👍 2
b
h
(still need to add some tests, but wanted to get feedback on the approach. It is the most streamlined thing I could come up with. We're limited because the PexRequest -> VenvPex pathway is used in ~30 places, so by far the easiest thing to do is piggyback on that
OK, once the cherrypick https://github.com/pantsbuild/pants/pull/19023 is merged, I am no longer blocking a 2.16.x RC
w
looks like there was a merge conflict, but otherwise: 🚢
b
(I'm blocking 2.16.x on 2 or 3 PRs 😕)
(I was kinda hoping to try out my new shiny GitHub Action 😛)
w
let me know when those are out.
ok, https://github.com/pantsbuild/pants/pull/19023 is in… @bitter-ability-32190: did you have anything else?
b
I thought I had https://github.com/pantsbuild/pants/pull/19020 but @broad-processor-92400 removed 
need-cherrypick
. It only changes some cosmetic stuff, so we can catch the next train
w
by “next train” do you mean not pick it to 
2.16.x
until after 
2.16.0
? i’m hoping that this can be the last 
rc
b
Ah, then no, I'd prefer this was cosmetically correct out of the gate.
w
k… get it in there.
b
Well this time the action worked. 😮‍💨 https://github.com/pantsbuild/pants/pull/19036
🎉 1
Open in Slack
PreviousNext
Powered by