https://pantsbuild.org/ logo
w

witty-crayon-22786

05/12/2023, 4:30 PM
hey folks: i’m on release duty today. i’ll execute any `rc`s / finals i can from
2.14.x
and
2.15.x
once the ARM shard is healthy again. but i’m going to hold off on
2.16.x
and
2.17.x
releases, since Benjy did/is-doing them in the last few days. i’ll aim to do a
2.16.0
final early next week, and cut the
2.17.x
branch at the same time
🎉 2
💗 2
p

polite-garden-50641

05/12/2023, 6:14 PM
can https://github.com/pantsbuild/pants/pull/18790 be cherry-picket into 2.16 ?
or is it to late in the stabilization phase?
w

witty-crayon-22786

05/12/2023, 6:15 PM
we generally shouldn’t cherry-pick features, and 2.16.x is quite late at this point
👍 1
is it blocking something?
p

polite-garden-50641

05/12/2023, 6:16 PM
upgrading docformatter to 1.6
w

witty-crayon-22786

05/12/2023, 6:17 PM
is that blocking something?
are older versions broken in some way?
p

polite-garden-50641

05/12/2023, 6:17 PM
no
f

fresh-cat-90827

05/12/2023, 6:50 PM
thanks a lot, @witty-crayon-22786! I can't wait to upgrade to 2.16 and start using the visibility feature in house!
w

witty-crayon-22786

05/15/2023, 5:50 PM
if you have bug fixes bound for 2.16.x, please get them in asap: I'd definitely like to get it cut midweek if possible
🙏 1
b

bitter-ability-32190

05/15/2023, 5:53 PM
Today I'm hoping to do more upgrade-to-Pants-2.16 work at $work, so hold youre breath 🙂
f

fresh-cat-90827

05/15/2023, 5:54 PM
yes, will do the same for some exploratory testing to find any issues before we can cut 2.16.0!
h

happy-kitchen-89482

05/15/2023, 6:22 PM
I have a blocker for 2.16.x in the works
👍 1
Should have it out today
mostly testing now
👍 2
b

bitter-ability-32190

05/15/2023, 6:47 PM
h

happy-kitchen-89482

05/16/2023, 6:43 AM
(still need to add some tests, but wanted to get feedback on the approach. It is the most streamlined thing I could come up with. We're limited because the PexRequest -> VenvPex pathway is used in ~30 places, so by far the easiest thing to do is piggyback on that
OK, once the cherrypick https://github.com/pantsbuild/pants/pull/19023 is merged, I am no longer blocking a 2.16.x RC
w

witty-crayon-22786

05/17/2023, 4:30 PM
looks like there was a merge conflict, but otherwise: 🚢
b

bitter-ability-32190

05/17/2023, 4:30 PM
(I'm blocking 2.16.x on 2 or 3 PRs 😕)
(I was kinda hoping to try out my new shiny GitHub Action 😛)
w

witty-crayon-22786

05/17/2023, 4:58 PM
let me know when those are out.
ok, https://github.com/pantsbuild/pants/pull/19023 is in… @bitter-ability-32190: did you have anything else?
b

bitter-ability-32190

05/18/2023, 5:09 PM
I thought I had https://github.com/pantsbuild/pants/pull/19020 but @broad-processor-92400 removed
need-cherrypick
. It only changes some cosmetic stuff, so we can catch the next train
w

witty-crayon-22786

05/18/2023, 5:11 PM
by “next train” do you mean not pick it to
2.16.x
until after
2.16.0
? i’m hoping that this can be the last
rc
b

bitter-ability-32190

05/18/2023, 5:11 PM
Ah, then no, I'd prefer this was cosmetically correct out of the gate.
w

witty-crayon-22786

05/18/2023, 5:11 PM
k… get it in there.
b

bitter-ability-32190

05/18/2023, 5:14 PM
Well this time the action worked. 😮‍💨 https://github.com/pantsbuild/pants/pull/19036
🎉 1