Why does

./pants fmt

log a warning when changes are made? Isn't that point of running formatters?

Yeah, I could go either way. It should probably be INFO, not WARN?

Yeah, that's what I was thinking. Preference we have internally is to not condition folks to "nominal" warnings.

WARN

definitely implies "a problem you need to be aware of" to me. For expected behavior,

INFO

does seem more appropriate. This has a bunch of interesting takes, and seem all to lean toward

INFO

as most befitting this kind of situation.

a PR to that effect would be very welcome! 🙂

Also, how is this possible?

fmt

says it made changes while

git status

shows nothing?

11:45:13.64 [WARN] Completed: Format with isort - isort made changes.
  <a bunch of files here>

+ isort made changes.
(3.8.10) ~/devel/monorepo (isort)$ gs
On branch isort
Your branch is ahead of 'master' by 2 commits.
  (use "git push" to publish your local commits)

nothing to commit, working tree clean

One formatter changes it one way, another changes it back

I ran

--only=isort

for this

I sometimes see what seems like “stale” output, if a previous run made changes… not sure why. Maybe that’s what you’re hitting too

a PR to that effect would be very welcome!

This one should be easy enough for me to tackle. I'll try to make it happen this weekend.

Cool, thank you!