https://pantsbuild.org/ logo
#development
Title
# development
b

bitter-ability-32190

05/09/2023, 3:01 PM
I think we may wanna spend some energy on this
urllib
issue that's come up twice (it doesn't help I am also getting bitten) https://pantsbuild.slack.com/archives/C046T6T9U/p1683574114661669 https://pantsbuild.slack.com/archives/C046T6T9U/p1683215047758389 are existing discussions in #general
We have informally talked about pulling the plug on our anonymous telemetry, Since
humbug
is the one pulling in
requests
(pulling in
urllib3
. Alternatively we can switch
humbug
to be provided in rule-code, and not part of the Pantsbuild environment (similar to
pex
, I believe)
b

busy-vase-39202

05/09/2023, 3:10 PM
imo it would be fine to pull
humbug
. We originally expected it would help us provide better tech support, but it hasn't really panned out for that. If we could substitute in some other telemetry tool, that could be worthwhile. But given that no major value being is being returned to the project and it has unfortunately become a blocker for some users, I think it's time to take humbug out of people's way one way or another.
b

bitter-ability-32190

05/09/2023, 3:35 PM
I'm also thinking we might wanna cherry pick to 2.16, since this is biting people. We could help them out sooner than 2.17
h

hundreds-father-404

05/09/2023, 3:58 PM
We shouldn't cherry-pick a deprecation to 2.16. But you could cherry-pick the non-deprecation parts
b

bitter-ability-32190

05/09/2023, 4:00 PM
E.g. the removal of behavior?
Well until then, I think I can't upgrade to Pants 2.16 😐
b

busy-vase-39202

05/09/2023, 5:03 PM
Does this violate the deprecation policy though? If users aren't losing any functionality or API that they depend on, and are gaining a bug fix, it seems like that is not a deprecation from a user perspective.
e

enough-analyst-54434

05/09/2023, 5:08 PM
Is it understood that this works fine?:
Copy code
jsirois@Gill-Windows:~ $ echo "urllib3<2" > foo.txt
jsirois@Gill-Windows:~ $ rm -r ~/.cache/nce/
jsirois@Gill-Windows:~ $ PIP_CONSTRAINT=foo.txt PANTS_VERSION=2.16.0rc1 pants
Bootstrapping Pants 2.16.0rc1 using cpython 3.9.15
Installing pantsbuild.pants==2.16.0rc1 into a virtual environment at /home/jsirois/.cache/nce/6621291ed4120fa45607b367abf7786ce496f389f27240712a63c31f1c438c21/bindings/venvs/2.16.0rc1
New virtual environment successfully created at /home/jsirois/.cache/nce/6621291ed4120fa45607b367abf7786ce496f389f27240712a63c31f1c438c21/bindings/venvs/2.16.0rc1.
No goals specified.
Use `pants help` to get help.
Use `pants help goals` to list goals.
jsirois@Gill-Windows:~ $ ls -l /home/jsirois/.cache/nce/6621291ed4120fa45607b367abf7786ce496f389f27240712a63c31f1c438c21/bindings/venvs/2.16.0rc1/lib/python3.9/site-packages/ | grep urllib3
drwxr-xr-x  6 jsirois jsirois   4096 May  9 10:08 urllib3
drwxr-xr-x  2 jsirois jsirois   4096 May  9 10:08 urllib3-1.26.15.dist-info
b

bitter-ability-32190

05/09/2023, 5:10 PM
And what's the intended way of getting that working with the global
plugins
option?
e

enough-analyst-54434

05/09/2023, 5:11 PM
I have no intentions. I'm just pointing out a thing.
b

bitter-ability-32190

05/09/2023, 5:13 PM
Ok
e

enough-analyst-54434

05/09/2023, 5:14 PM
Further:
Copy code
jsirois@Gill-Windows:~ $ rm -r ~/.cache/nce/
jsirois@Gill-Windows:~ $ echo "PIP_CONSTRAINT=foo.txt" > .env
jsirois@Gill-Windows:~ $ PANTS_VERSION=2.16.0rc1 pants
Bootstrapping Pants 2.16.0rc1 using cpython 3.9.15
Installing pantsbuild.pants==2.16.0rc1 into a virtual environment at /home/jsirois/.cache/nce/6621291ed4120fa45607b367abf7786ce496f389f27240712a63c31f1c438c21/bindings/venvs/2.16.0rc1
New virtual environment successfully created at /home/jsirois/.cache/nce/6621291ed4120fa45607b367abf7786ce496f389f27240712a63c31f1c438c21/bindings/venvs/2.16.0rc1.
No goals specified.
Use `pants help` to get help.
Use `pants help goals` to list goals.
jsirois@Gill-Windows:~ $ ls -l /home/jsirois/.cache/nce/6621291ed4120fa45607b367abf7786ce496f389f27240712a63c31f1c438c21/bindings/venvs/2.16.0rc1/lib/python3.9/site-packages/ | grep urllib3
drwxr-xr-x  6 jsirois jsirois   4096 May  9 10:14 urllib3
drwxr-xr-x  2 jsirois jsirois   4096 May  9 10:14 urllib3-1.26.15.dist-info
So, if that's useful - there you go.
b

bitter-ability-32190

05/09/2023, 5:25 PM
That allows me to use
pants help
as a workaround. Unfortunately
PANTS_SOURCE
is afflicted, but I think that's going to be the case even with
humbug
gone, so separate issue
e

enough-analyst-54434

05/09/2023, 5:31 PM
I think
PANTS_SOURCE
, which just runs the Pants repo
./pants
script, uses pip install; so the
PIP_*
env var trick should still work.
h

happy-kitchen-89482

05/09/2023, 5:33 PM
I think it's fine to remove telemetry (most people turn it off anyway), but want to be sure that is the consensus opinion before doing so. I don't think we should backport to 2.16 if we can avoid it.
b

broad-processor-92400

05/09/2023, 6:22 PM
Does an option like adding
urllib3<2
to pants’ requirements work (potentially with BUILD file adjustments to have it come through)? If it does, might that be lower risk/lower impact?
e

enough-analyst-54434

05/09/2023, 6:33 PM
Yes, but not retroactively. The
PIP_*
trick is a retroactive workaround for install of a
pantsbuild.pants
distribution without that.
b

broad-processor-92400

05/09/2023, 7:21 PM
Yeah for sure, hence, if that is safer to cherry-pick to 2.15 and 2.16, we’d fix more users sooner, versus removing humbug as the only fix, only in 2.17
e

enough-analyst-54434

05/09/2023, 8:35 PM
Ah, gotcha. Decouple humbug issue from urllib3 issue. Sounds sane to me!
👍 1
b

broad-processor-92400

05/09/2023, 9:40 PM
I've proposed that change in https://github.com/pantsbuild/pants/pull/18959 as an option to cherry-pick (and #18952 can thus remain focused on 2.17).
b

bitter-ability-32190

05/09/2023, 9:43 PM
You rock
❤️ 1
b

broad-processor-92400

05/10/2023, 9:44 PM
I have a sense we haven't resolved this conversation? • Based on all the s, it seems clear that 18952 has consensus to merge (other than potentially double checking the wheel's deps) • But, it's unclear about whether it'll be cherry-picked. • Thus, I'm unclear on whether to merge/cherry-pick 18959, or just close it as not necessary. I have personally have no point of view, and am happy to go with either plan, but someone will have to let me know 😄
b

bitter-ability-32190

05/10/2023, 9:45 PM
I think your PR is cherry pickable, mine isn't
Just to be safe
b