I assume the answer is legacy: Why is `src/python/...
# developmentp
proud-dentist-22844
04/07/2023, 7:30 PMI assume the answer is legacy: Why is
src/python/pants/backends/python/goals/setup_py.pysetup_py.pypackage_dists.py✅ 1
h
hundreds-father-404
04/07/2023, 7:34 PMYep, we had a dedicated goal; https://v1.pantsbuild.org/options_reference.html#setup-py
hundreds-father-404
04/07/2023, 7:34 PMI think it's probably fine (and good!) to rename
p
proud-dentist-22844
04/07/2023, 7:35 PMAh. API wise is moving that file something we could do for 2.16.x? Or is that too big of a plugin API change for an RC?
h
hundreds-father-404
04/07/2023, 7:36 PMI don't think we could do that for an RC. We're supposed to avoid API changes because the goal is stabilization
p
proud-dentist-22844
04/07/2023, 7:37 PMGot it. Then two PRs it is, one minor refactor for 2.16.x, and the bigger move for 2.17.x 😄
h
happy-kitchen-89482
04/07/2023, 7:47 PMYeah, that name is historical, fine to change it
p
proud-dentist-22844
04/07/2023, 7:50 PMMy bigger change moves most of that file to util_rules/package_dist.py and leaves goals/package_dist.py as a bare bones rule + rules registration 🙂
proud-dentist-22844
04/07/2023, 8:03 PMRFR https://github.com/pantsbuild/pants/pull/18701 (for the one I want to cherry-pick to 2.16.x)
This only has [+40 -21] lines changed.
✅ 1
proud-dentist-22844
04/07/2023, 8:13 PMAnd here’s the somewhat larger rename PR: https://github.com/pantsbuild/pants/pull/18702 (18701 should be merged first).
I say somewhat larger because it only changes [+144 -116] lines.
2 Views