https://pantsbuild.org/ logo
#development
Title
# development
p

proud-dentist-22844

04/07/2023, 7:30 PM
I assume the answer is legacy: Why is
src/python/pants/backends/python/goals/setup_py.py
called
setup_py.py
instead of something like
package_dists.py
?
1
h

hundreds-father-404

04/07/2023, 7:34 PM
I think it's probably fine (and good!) to rename
p

proud-dentist-22844

04/07/2023, 7:35 PM
Ah. API wise is moving that file something we could do for 2.16.x? Or is that too big of a plugin API change for an RC?
h

hundreds-father-404

04/07/2023, 7:36 PM
I don't think we could do that for an RC. We're supposed to avoid API changes because the goal is stabilization
p

proud-dentist-22844

04/07/2023, 7:37 PM
Got it. Then two PRs it is, one minor refactor for 2.16.x, and the bigger move for 2.17.x 😄
h

happy-kitchen-89482

04/07/2023, 7:47 PM
Yeah, that name is historical, fine to change it
p

proud-dentist-22844

04/07/2023, 7:50 PM
My bigger change moves most of that file to util_rules/package_dist.py and leaves goals/package_dist.py as a bare bones rule + rules registration 🙂
RFR https://github.com/pantsbuild/pants/pull/18701 (for the one I want to cherry-pick to 2.16.x) This only has [+40 -21] lines changed.
1
And here’s the somewhat larger rename PR: https://github.com/pantsbuild/pants/pull/18702 (18701 should be merged first). I say somewhat larger because it only changes [+144 -116] lines.
2 Views