https://pantsbuild.org/ logo
#development
Title
# development
a

ambitious-actor-36781

04/04/2023, 11:27 PM
I want to have a crack at extending the way
test
can collect additional stuff. Currently you can define
[test].extra_env_vars
to inject extra stuff into the env, and
runtime_package_dependencies
to add packageable targets to the test process digest. But from a quick skim of the code, all of this is replicated in each backends subprocess call. My thinking is to push it up a level so the
TestRequest
contains a
env_vars
and a
additional_digest
that the backend folds into its subprocess calls. Then
extra_env_vars
and
runtime_package_dependencies
could be implemented as Union rules, and other plugins can then set up prerequisites for tests as needed. ie. for my use case, I want to upload a target to a 3rd party and run integration tests against the remote resource. ... Is there a preferred process for going about making this sort of (large?) change?
a

ancient-vegetable-10556

04/05/2023, 4:13 PM
Yes! It’s probably worth creating a github discussion with an overview of the design changes you’d like to make, so that we can discuss them.
👍 1