OK; hopefully last question :joy: I run matrix tes...
# pluginsg
gorgeous-winter-99296
03/16/2023, 11:30 AMOK; hopefully last question 😂 I run matrix tests for pants .14, .15, .16a0. However; the generated testutil dependency is hard-limited:
Copy code
['pantsbuild.pants.testutil<2.16,>=2.15.0a0', 'pantsbuild.pants<2.16,>=2.15.0a0']b
bitter-ability-32190
03/16/2023, 12:06 PMI think you'd need multiple lockfiles + multiple resolves 😞
g
gorgeous-winter-99296
03/16/2023, 2:46 PMRegenerating the lock in each CI variant seems easier. 😛
b
bitter-ability-32190
03/16/2023, 3:02 PMWell its one-and-done
bitter-ability-32190
03/16/2023, 3:02 PMBut whatever you feel like is easier is defintely the right choice for you 🙂
g
gorgeous-winter-99296
03/16/2023, 3:05 PMI think - because I need to run with different PANTS_VERSION - I'd also need to triplicate the CI step etc.
b
bitter-ability-32190
03/16/2023, 3:07 PMProbably not? I think each test would parametrize on resolve, with each possible pants version as a resolve. And those each have the lockfile with the pants version.
So Pants would run your tests in parallel across all pants versions each in its own process.
Does that make sense?
g
gorgeous-winter-99296
03/16/2023, 3:10 PMNo! But does run_pants run a different pants than the one I'm running the test from?
gorgeous-winter-99296
03/16/2023, 3:10 PMOtherwise I don't see how it'd work. 😛
b
bitter-ability-32190
03/16/2023, 3:14 PMIt uses the Pants referenced in the dependency... I think.... I'm like 84% sure
bitter-ability-32190
03/16/2023, 3:14 PMAnd thats high enough to try it out 😛
g
gorgeous-winter-99296
03/16/2023, 4:08 PM🥳 It works! I have to make every python_source be parametrised over every variant of Pants which is eh, maybe suboptimal...
Copy code
pants-plugins/oci/pants_backend_oci/util_rules/layer.py@resolve=pants-plugins
pants-plugins/oci/pants_backend_oci/util_rules/layer.py@resolve=pants-214
pants-plugins/oci/pants_backend_oci/util_rules/layer.py@resolve=pants-215
pants-plugins/oci/pants_backend_oci/util_rules/layer.py@resolve=pants-216
pants-plugins/oci/pants_backend_oci/util_rules/oci_sha.py@resolve=pants-216
pants-plugins/oci/pants_backend_oci/util_rules/oci_sha.py@resolve=pants-plugins
pants-plugins/oci/pants_backend_oci/util_rules/oci_sha.py@resolve=pants-214
pants-plugins/oci/pants_backend_oci/util_rules/oci_sha.py@resolve=pants-215
pants-plugins/oci/pants_backend_oci/util_rules/pull_image_bundle.py@resolve=pants-plugins
pants-plugins/oci/pants_backend_oci/util_rules/pull_image_bundle.py@resolve=pants-214
pants-plugins/oci/pants_backend_oci/util_rules/pull_image_bundle.py@resolve=pants-215
pants-plugins/oci/pants_backend_oci/util_rules/pull_image_bundle.py@resolve=pants-216
pants-plugins/oci/pants_backend_oci/util_rules/unpack.py@resolve=pants-plugins
pants-plugins/oci/pants_backend_oci/util_rules/unpack.py@resolve=pants-214
pants-plugins/oci/pants_backend_oci/util_rules/unpack.py@resolve=pants-215
pants-plugins/oci/pants_backend_oci/util_rules/unpack.py@resolve=pants-216b
bitter-ability-32190
03/16/2023, 4:09 PMLook up
__defaults__bitter-ability-32190
03/16/2023, 4:09 PMbut also woohoo!
g
gorgeous-winter-99296
03/16/2023, 4:10 PMOh for sure, no way I'd add the resolve in every single directory 😛 Still quadruples the amount of targets
gorgeous-winter-99296
03/16/2023, 5:29 PMOh, geez. NOPE. Parametrizing the sources with multiple pants variants breaks isort. It starts thinking pants is a first-party package...
b
bitter-ability-32190
03/16/2023, 5:30 PMisortbitter-ability-32190
03/16/2023, 5:30 PMI'd just adjust the config. Don't throw out the baby with the bathwater
g
gorgeous-winter-99296
03/16/2023, 5:35 PMSeems like the config discovery gets confused. If I just set
Copy code
[isort]
config = "['pyproject.toml']"3 Views