related to the above thread, i’ve been investigati...
# developmentw
witty-crayon-22786
03/14/2023, 10:43 PMrelated to the above thread, i’ve been investigating whether to proceed with switching to symlinks in https://github.com/pantsbuild/pants/pull/18153, based on a discussion with @enough-analyst-54434:
witty-crayon-22786
03/14/2023, 10:43 PMhave created an issue here discussing that: https://github.com/pantsbuild/pants/issues/18507
witty-crayon-22786
03/14/2023, 10:44 PMwill post benchmarks when / if i’ve reproduced them in a single
hyperfinee
enough-analyst-54434
03/14/2023, 10:46 PMWhat does tmp have to do with anything other than we currently use it? We could be using some dir guaranteed to be file system coresident for hard linking success IIUC.
w
witty-crayon-22786
03/14/2023, 10:48 PMyea, that’s the suggestion on the issue. a persistent directory is faster than
/tmptmpfse
enough-analyst-54434
03/14/2023, 10:48 PMAll the tmp talk seems confusing.
w
witty-crayon-22786
03/14/2023, 10:48 PMthe relevance is primarily: “we are currently using `/tmp`… and for some users, that might actually have been a `tmpfs`”
b
bitter-ability-32190
03/14/2023, 10:48 PMOne additional metric (for me at least) is my homedir is encrypted. So possibly placing all of the above outside would net me some gain? Another dimension to test for sure
e
enough-analyst-54434
03/14/2023, 10:49 PMFilesystems and paths aside, it just seems symlink vs hardlink is totally separable from fs perf.
enough-analyst-54434
03/14/2023, 10:50 PMChoosing symlink makes an extra decision for you in Windows. You now force developer mode
enough-analyst-54434
03/14/2023, 10:50 PMWhich sounds reasonable on paper, but we have at least one user who can't use that.
w
witty-crayon-22786
03/14/2023, 10:53 PMyea, i’m skittish about symlinks in general, since they are also much more visible. it’s possible that even for a fallback we will want to copy, to avoid rules needing to care (mentioned on the ticket)