re: <https://github.com/pantsbuild/pex/pull/722>: ...
# pexw
witty-crayon-22786
05/06/2019, 5:03 PMre: https://github.com/pantsbuild/pex/pull/722: i feel pretty strongly that SOURCE_DATE_EPOCH is a misfeature when compared to them having specified a particular date that tools should use
witty-crayon-22786
05/06/2019, 5:03 PMIMO, leave a NB near the deterministic datetime explaining why we don't use it.
witty-crayon-22786
05/06/2019, 5:04 PM...oh. hm.
witty-crayon-22786
05/06/2019, 5:05 PMor we could have pants guarantee to specify it in all cases where we invoke pex? not loving that, as it seems unnecessarily fragile
h
hundreds-father-404
05/06/2019, 5:42 PMOkay. I am okay with removing it if we are willing to revisit the decision if we get feedback from users that they care about this feature.
Otherwise, simpler works for me. It makes our docs simpler, can make the function a constant, and simpler unit test
w
witty-crayon-22786
05/06/2019, 5:44 PMok, thanks.
h
hundreds-father-404
05/06/2019, 5:44 PMI would like to be a good Linux citizen, although it is also worth noting that the intent of the reproducible builds website is to make tools reproducible for security, that you know the binary was not tampered with.
That is not really what we’re after, and you’re right it’s probably a misfeature for that reason
hundreds-father-404
05/06/2019, 5:44 PMBuck and Bazel don’t seem to respect that env var
w
witty-crayon-22786
05/06/2019, 5:44 PMi expect for exactly this reason
witty-crayon-22786
05/06/2019, 5:45 PMyou would then not be able to reproduce a build between osx/windows and linux without additional effort
witty-crayon-22786
05/06/2019, 5:46 PMthe only benefit i see to the env var is that if you have two different tools that might produce the same file, you could then convince them to produce it with the same timestamp
👍 1
witty-crayon-22786
05/06/2019, 5:46 PMbut... that is very, very tenuous