Hey <@U04S45AHA> and <@U06A03HV1>, I got all accep...
# pexh
hundreds-father-404
05/05/2019, 11:24 PMHey @enough-analyst-54434 and @witty-crayon-22786, I got all acceptance tests passing for reproducibility(!), except for the sdist test when ran specifically on PyPi. The Pex fails to build because it can’t resolve pycparser https://travis-ci.org/pantsbuild/pex/jobs/528583459#L841
Do you both agree that it would be fine to skip this test when using PyPi?
w
witty-crayon-22786
05/06/2019, 5:09 PMnot sure i understand this one. fine with skipping if we think that it's an issue with pex that should be fixed in a seperate PR
witty-crayon-22786
05/06/2019, 5:11 PMif it's an issue with the package that is being tested, imo, should switch to a better behaved package
h
hundreds-father-404
05/06/2019, 5:48 PMI’ll experiment more why pycparser can’t be built via PyPy. I suspect pycparser requires CPython to work
My point is I don’t think it’s a good use of our time to research this more though. We know PyPy is reproducible in general, just the sdist test fails because of the package failing to resolve.
w
witty-crayon-22786
05/06/2019, 5:48 PMsure
witty-crayon-22786
05/06/2019, 5:48 PMfine as a TODO to figure out which of the above it is
👍 1