https://pantsbuild.org/ logo
#pex
Title
# pex
w

witty-crayon-22786

09/27/2018, 11:15 PM
i was just asking if that was the ticket you were referring to. currently running the suite locally, and i don't see anything that looks like a resolve failure yet
e

enough-analyst-54434

09/27/2018, 11:19 PM
Ok, if it does go green, the two conflicting comments / conditions in the BUILD seem like a problem to me. An edit to explain how the two work together would be great if you have come to understand it. I can't understand it.
w

witty-crayon-22786

09/27/2018, 11:22 PM
it's not clear to me how they're in conflict... can you explain?
e

enough-analyst-54434

09/27/2018, 11:23 PM
Well, my fix in pex was for a test pinned to py2.7 and the problem releases in ipy* were both dropping support for py2
The pinning low makes them be py27 compliant. The test is for the opposite, py3 only
e

enough-analyst-54434

09/27/2018, 11:24 PM
The comment on tope of the target reads in conflict with the comment you adding in the middle
How does 3 even work then?
Maybe the middle comment needs to say the old versions work with both
This is something I did not verify or need to in my pex fix, but if things work here, seems like must be the case
w

witty-crayon-22786

09/27/2018, 11:25 PM
what is blacklisted in the test is
functools
, rather than jupyter itself
e

enough-analyst-54434

09/27/2018, 11:25 PM
Ack
maybe its only me who finds the full context of the BUILD makes no sense
Let's get the CI green
w

witty-crayon-22786

09/27/2018, 11:26 PM
well, you would know better. i can try and meld the comments in the meantime.
e

enough-analyst-54434

09/27/2018, 11:27 PM
No, its not a python thing it just reads as making no sense. How come a python3 compat target needs its deps pinned to py27 compat
If there is a 2nd dep it is non-local
And so needs a local comment to make the file make sense - it seems to me
w

witty-crayon-22786

09/27/2018, 11:27 PM
ok.
e

enough-analyst-54434

09/27/2018, 11:28 PM
I think that's true - right? If you just read that file there is no hint the lib is dependeded on push/pull because th local dep is py3 only.
w

witty-crayon-22786

09/27/2018, 11:28 PM
Copy code
# This library requires pex blacklisting under python 3, because the pex resolver will error out
# on a transitive requirement of jupyter (functools32).
#
# This test also runs under python 2 though, and so in order to avoid dep floats of jupyter's
# transitive deps (which can float upward to versions that do not support python 2), we pin them.
python_requirement_library(
  name='reqlib',
  requirements=[
    python_requirement('jupyter==1.0.0'),
    python_requirement('ipykernel<5'),
    python_requirement('ipython<6'),
  ]
)
?
e

enough-analyst-54434

09/27/2018, 11:30 PM
Awesome - ty.
w

witty-crayon-22786

09/27/2018, 11:31 PM
sure thing