quaint-telephone-89068
11/19/2022, 1:22 AMoverrides for a python_requirement to add missing dependencies (in other words likely for a bad 3rd party dep) it would be sweet if I didn't have to do it again for all the python_distribution targets that depend on this 3rd party library.
Describe the solution you'd like
Include the explicitly added dependencies on 3rd party deps in the list of required dists in setup.py.
Describe alternatives you've considered
Manually duplicating the dependency on the python_distribution. Tedious and error prone.
Additional context
Take this dist for example:
https://github.com/kaos/lockfile-diff/blob/f631695c838811acf5c7b8b00a02d2e4cc5db638/src/lockfile_diff/BUILD#L3-L10
Where I figured the phx-class-registry library requires pkg_resources from setuptools but it isn't listed, so sorted it with this override:
https://github.com/kaos/lockfile-diff/blob/f631695c838811acf5c7b8b00a02d2e4cc5db638/3rdparty/BUILD#L6-L10
However, this version of my lockfile-diff is still broken, as I didn't also include setuptools as a dependency for my distribution. Foot-gun blast.
pantsbuild/pantsuser
12/02/2022, 8:24 PM