I got it all working Thanks a ton for the help

Join Slack

I got it all working! Thanks a ton for the help <@...

# plugins

calm-ambulance-65371

10/08/2020, 10:50 PM

I got it all working! Thanks a ton for the help @hundreds-father-404

👏 2

👍 1

hundreds-father-404

10/08/2020, 11:15 PM

Awesome to hear! I’m glad it’s working. You might need to make some small tweaks when you upgrade to new Pants versions, as the Rules API isn’t completely stable yet. But we try to minimize the changes, and will post in this channel / elsewhere a guide on how to upgrade

hundreds-father-404

10/08/2020, 11:18 PM

Oh also one enhancement idea I had for your plugin: it assumes that

setup.py

is in the same directory as where you declare your

cython_library

. You can make this assumption explicit by implementing the method

validate_resolved_files()

on `CythonSources`:

Copy code

def validate_resolved_files(self, files: Sequence[str]) -> None:
   super().validate_resolved_files(files)
   if os.path.join(self.address.spec_path, "setup.py") not in files:
    raise InvalidFieldException(...)

👍 1

hundreds-father-404

10/09/2020, 7:32 PM

Btw, let us know if you’re interested in writing automated tests for your plugin. We’d be happy to help. We wrote ~reference style docs for it, but haven’t started yet with guided examples. https://www.pantsbuild.org/docs/rules-api-testing

witty-crayon-22786

10/26/2020, 5:56 PM

if you’re interested in upstreaming the plugin to the Pants repo, we’d also be happy to help with that, as it will mean you don’t have to deal with changes before the plugin API stabilizes.

3 Views

Open in Slack

Previous Next