Hopefully <@UQ1678BE1> <@UQYU3FV27> no one will de...
# plugins
h
Hopefully @jolly-midnight-72759 @damp-quill-59187 no one will deal with the same confusing error message you both had, after this PR. https://github.com/pantsbuild/pants/pull/11081 Feedback appreciated on the PR description about the wording of the new error message!
j
The "After" error message is clearer. There is still some ambiguity about which input is at fault. Is
UnexpectedTargets
supposed to be a single object of type
Addresses
or the
Addresses
part? I guess it is "obvious" that it is the
Addresses
part. Is it true that `Get(A, B)`expects
A
to be of type
UnexpandedTargets
and
B
to be of type
Addresses
? If yes, then maybe:
Copy code
Exception: Invalid input to `Get(A, B)`. Expected `B` to be of type `Addresses`, but got value `int` of type `int` instead.
I thought I was just going to give a 👍🏽 but I guess I have Opinions™. I'll put the rest in the PR where it belongs.
👖 1
💯 1