I would love a code review on two plugins I wrote:...
# plugins
p
I would love a code review on two plugins I wrote: https://github.com/st2sandbox/st2/tree/pants/pants-plugins stevedore_extensions -> enables defining entry_point data (typical of a stevedore extension) as targets and then depending on them via stevedore_namespaces field on python_tests targets. It uses the PytestSetupPlugin hook to generate egg-info data based on the target metadata, making it possible for stevedore to find the extensions while testing. uses_services -> a contributor UX improvement - Uses the PytestSetupPlugin hook to check for services like mongo before running tests that "use" those services (uses is a field on python_tests targets). This allows us to bail out as early as possible with an error message explaining how to install / start the required service. They are both essentially functional 🙂. Please let me know how they could be better. 🙂
👀 1
✔️ 1
h
@proud-dentist-22844 I'll write a GitHub issue? That way I can do code links
p
Perfect
h
p
Thanks! I'll work through your feedback prob on Saturday
❤️ 1