How can I extend ` pants tailor` I d like to have it add `sk Pants #plugins

How can I extend `./pants tailor` ? I'd like to ha...

proud-dentist-22844

05/30/2021, 4:39 AM

How can I extend

./pants tailor

? I'd like to have it add

skip_pylint=True

whenever it adds a

python_tests()

target. I would also like it to add another target (possibly a macro for a files target) in any directory with

pack.yaml

(which is a market file for source roots).

proud-dentist-22844

05/30/2021, 5:37 AM

K. I see how I can register a

PutativeTargetsRequest

to add new targets for the relevant files near

pack.yaml

, but it's not clear how I can add extra kwargs to the python targets identified by the python

find_putative_targets

rule.

happy-kitchen-89482

05/30/2021, 7:34 AM

Yeah, adding new targets should be easy, modifying existing ones... let me take a look and remind myself how this works.

proud-dentist-22844

05/30/2021, 7:03 PM

Hmm. I figured I would create a macro for a files target, and then my

PutativeTargets

would add that macro to the BUILD files. But, macros are defined much later, so am I better off to create a new files-like target?

proud-dentist-22844

05/31/2021, 12:37 AM

Here's my plugin: https://github.com/st2sandbox/st2/tree/pants/pants-plugins/pack_metadata Do you have any feedback? Also, it looks like we would need another hook similar to setup_py to allow adjusting the targets that tailor already knows how to generate.

happy-kitchen-89482

05/31/2021, 5:57 AM

Small bit of feedback: Do you expect the pack_metadata to need

dependencies=

? If not you can omit the

Dependencies

from the core_fields

happy-kitchen-89482

05/31/2021, 5:59 AM

I think this should work with macros?

happy-kitchen-89482

05/31/2021, 6:00 AM

Your

PutativeTargets

really just contains text components for generating BUILD file entries

happy-kitchen-89482

05/31/2021, 6:00 AM

True, you wouldn't be able to call

for_target_type()

to create the

PutativeTarget

and would have to invoke the ctor directly, but I think that should work OK with macros, unless you have evidence to the contrary?

👍 1

happy-kitchen-89482

05/31/2021, 6:03 AM

And re modifying the fields in the created python_tests targets - still thinking about this

happy-kitchen-89482

05/31/2021, 6:05 AM

Right now we just run all the tailors concurrently: https://github.com/pantsbuild/pants/blob/main/src/python/pants/core/goals/tailor.py#L390

happy-kitchen-89482

05/31/2021, 6:06 AM

There is no good story if multiple attempt to claim the same sources

happy-kitchen-89482

05/31/2021, 6:06 AM

We handle conflicts with existing targets, but not conflicts between putative target

👍 1

happy-kitchen-89482

05/31/2021, 6:06 AM

So need to fix that

proud-dentist-22844

05/31/2021, 3:40 PM

ok. My metadata target seems to work. It wasn't as complex as I thought. I can switch to a macro if I do something more complex.

proud-dentist-22844

05/31/2021, 3:53 PM

Small bit of feedback: Do you expect the pack_metadata to need
dependencies=
? If not you can omit the
Dependencies
from the core_fields

I'm undecided. I'm still figuring out how to wire up all the dependencies. I may need the

dependencies

field depending on the final state.

Open in Slack

Previous Next