I’m a bit interested in starting to look at a dock...
# plugins
c
I’m a bit interested in starting to look at a docker plugin (https://github.com/pantsbuild/pants/issues/2648) as a POC. Probably more work than I would finish in a sensible amount of time, but think it would be fun, none the less.
🙌 1
Any pointers, wishes, features etc on how it should work, if you could make any wish 🙂
On a high level..
h
That'd be great, thank you Andreas for taking initiative with one of the most requested features! We have the backend/experimental folder to allow development of things like this with lots of flexibility to change the design as you go. You can more easily add incremental things that way. I suspect a great first step is to get Pants to build a Dockerfile for you. Use BinaryPaths to discover Docker, define a docker target type, and run the right docker commands to build. See https://github.com/compyman/pants-docker for possible inspiration, cc @average-australia-85137
👍 1
c
Awesome. Thanks. Also reading up a bit on what they’ve done with the bazel docker rules https://github.com/bazelbuild/rules_docker gives a few ideas. So, yes, managing images and building Dockerfiles is a good start.
1
h
I liked Nate's use of "unions" to make it extensible for certain dependencies to be pre-processed. That's great that it's a plugin hook for future users
c
great to be able to draw on as many experiences as possible from earlier work 👍 extensibility is great 🙂
h
Yeah, this has only waited on needing someone with a use-case to actually do it.
So thanks for picking it up!
I have a branch where I did the "tailor" part, I can push that somewhere
1
💯 1
so it generates docker_image targets for you
Was just messing around with it mostly to test tailor
c
I’d be happy for some critique/brainstorming on user facing API here, when you get back.. https://github.com/pantsbuild/pants/pull/12363#issuecomment-882012249
a
Hi! I'm the person who wrote that original plugin up there! (just got back from vacation!) which is working pretty well for my company! I'm available here if you want to chat!
👍 1
c
OK, I think we’ve got enough features to review in one PR.. https://github.com/pantsbuild/pants/pull/12363
How much of the docs are generated from source, and how much do we need to author “manually”.. ? Looks like the reference section is pulled from the source code..
h
Only the reference section comes from source code
👍 1