I need to extract a zipfile coming from a `DigestC...
# pluginsb
bitter-ability-32190
04/12/2022, 3:09 PMI need to extract a zipfile coming from a
DigestContentszipflleDigestContents✅ 1
f
fast-nail-55400
04/12/2022, 3:14 PMThere are archive extraction rules in Pants.
fast-nail-55400
04/12/2022, 3:14 PMpants.core.util_rules.archive I think
b
bitter-ability-32190
04/12/2022, 3:14 PMmaybe_extract_archivebitter-ability-32190
04/12/2022, 3:23 PMNoooo my archive doesn't end in a standard suffix 😭
bitter-ability-32190
04/12/2022, 3:23 PMGuess my post yesterday is relevant: https://pantsbuild.slack.com/archives/C01CQHVDMMW/p1649698734424639
bitter-ability-32190
04/12/2022, 3:24 PMAlthough if I was to upstream this I think I could add an input to
maybe_extract_archivebitter-ability-32190
04/12/2022, 3:25 PMWait, I can just use the helper rules for my specific case
bitter-ability-32190
04/12/2022, 3:25 PMNevermind that's just running a process and that's ugly
h
hundreds-father-404
04/12/2022, 3:57 PMFeel free to refactor the core rules to make this more useful. That is an anti-pattern that you need to rename the file
b
bitter-ability-32190
04/12/2022, 4:09 PMSince the rule doesn't request the file contents, it can only go by pathname. The only way to handle this without asking for contents would be to either have the rule take in what archive type it is or start whitelisting more "known" extensions (in this case
whlh
hundreds-father-404
04/12/2022, 4:10 PMCan you have the plug-in author hardcode the value? If not hard coded, then we fall back to our default heuristic?
b
bitter-ability-32190
04/12/2022, 4:10 PMThat would be the former, yeah
coke 1
h
hundreds-father-404
04/12/2022, 4:10 PMSeems like a sensible change to me
10 Views