Anyone got a nudge. I'm extracting and archive wit...
# pluginsb
bitter-ability-32190
04/21/2022, 4:28 PMAnyone got a nudge. I'm extracting and archive with an absolute symlink:
Error expanding output globs: Failed to read link ... Absolute symlinkProcessExtractedArchiveoutput_directories✅ 1
bitter-ability-32190
04/21/2022, 4:39 PM--excludetarlz4-Iw
witty-crayon-22786
04/21/2022, 4:40 PMhm… process output capture should be symlink oblivious
b
bitter-ability-32190
04/21/2022, 4:41 PMHere's the message:
Copy code
Error expanding output globs: Failed to read link "/tmp/process-executionhxcvDG/__extract_archive_dir/somedir/tools/python/python": Absolute symlink: "/usr/bin/python2.7"w
witty-crayon-22786
04/21/2022, 4:42 PMyea… sec.
b
bitter-ability-32190
04/21/2022, 4:42 PMFWIW I don't need the symlink so
--exclude pythonw
witty-crayon-22786
04/21/2022, 4:43 PMthis is also sortof a performance issue though if we’re actually expanding them. lemme see.
witty-crayon-22786
04/21/2022, 4:44 PMmm… yea, small bug.
b
bitter-ability-32190
04/21/2022, 4:44 PM🤏🐛
w
witty-crayon-22786
04/21/2022, 4:55 PMhm. so i’ve implemented this, but before i add tests, @fast-nail-55400: what are your thoughts on the probability of us ever wanting to add symlink support to Pants’ use of REAPI?
b
bitter-ability-32190
04/21/2022, 4:56 PMWhat's the new behavior of symlinks in this scenario
w
witty-crayon-22786
04/21/2022, 4:56 PMthey would be captured as files
b
bitter-ability-32190
04/21/2022, 4:57 PMBut when materialized they are still symlinks? 🤔
w
witty-crayon-22786
04/21/2022, 4:57 PMno: they are files.
witty-crayon-22786
04/21/2022, 4:57 PMoh, wait, sorry.
witty-crayon-22786
04/21/2022, 4:57 PMyou mean what would the new behavior be if we implemented REAPI’s support for symlinks?
witty-crayon-22786
04/21/2022, 4:58 PMwith REAPI symlinks, we would capture as a symlink and restore as a symlink, yea.
b
bitter-ability-32190
04/21/2022, 4:58 PMNo sorry, I meant new behavior locally.
bitter-ability-32190
04/21/2022, 4:58 PMI assume then the previously symlink is now just a copy of the thing it links to?
w
witty-crayon-22786
04/21/2022, 4:59 PMthey would be captured as filesboth the new and old behavior is that symlinks are captured as files. but the old behavior is that they cannot escape the sandbox. the new behavior would mean that we would just not ever check whether something was a symlink
b
bitter-ability-32190
04/21/2022, 4:59 PMAh I see
bitter-ability-32190
04/21/2022, 5:00 PMBetter than exclusion args to tar! 🙏
w
witty-crayon-22786
04/21/2022, 5:00 PMwe’d always
statf
fast-nail-55400
04/21/2022, 5:05 PMSymlinks are separate entity in REAPI from files and directories.
fast-nail-55400
04/21/2022, 5:06 PMSo if we support them in REAPI then we capture them as symlinks.
w
witty-crayon-22786
04/21/2022, 5:06 PM@fast-nail-55400: added a comment here: https://github.com/pantsbuild/pants/pull/15211
7 Views