Running `mypy` on some plugin code I'm seeing a pu...
# pluginsb
bitter-ability-32190
05/04/2022, 4:12 PMRunning
mypy Copy code
pants-plugins/mypy_is_a_linter/register.py:4: error: Module
'pants.backend.python.typecheck.mypy' has no attribute 'skip_field'
from pants.backend.python.typecheck.mypy import skip_field, subsystem
^
pants-plugins/mypy_is_a_linter/register.py:13: error: Module
'pants.backend.python.util_rules' has no attribute 'pex_from_targets'
from pants.backend.python.util_rules import pex_from_targets./pants --no-process-cleanup lint pants-plugins/mypy_is_a_linter/register.pypantsbuild.whl✅ 1
h
hundreds-father-404
05/04/2022, 4:14 PMwait yeah what
😆 1
hundreds-father-404
05/04/2022, 4:14 PMidk why it has been so hard to get type hints working w/ pants plugins
b
bitter-ability-32190
05/04/2022, 4:14 PMI have maybe 6 different plugins. This is the only one complaining. And it's only these imports
h
hundreds-father-404
05/04/2022, 4:15 PMb
bitter-ability-32190
05/04/2022, 4:16 PMFWIW here's the imports for that file. I guess the others are OK, but why?
Copy code
from pants.backend.python.typecheck.mypy import skip_field, subsystem
from pants.backend.python.typecheck.mypy.rules import (
MyPyPartition,
MyPyPartitions,
MyPyRequest,
mypy_determine_partitions,
mypy_typecheck_partition,
)
from pants.backend.python.typecheck.mypy.subsystem import MyPy
from pants.backend.python.util_rules import pex_from_targets
from pants.core.goals.check import CheckResult
from pants.core.goals.lint import LintResults, LintTargetsRequest
from pants.engine.rules import Get, MultiGet, collect_rules, rule
from pants.engine.unions import UnionRule
from pants.util.logging import LogLevelbitter-ability-32190
05/04/2022, 4:21 PMDatapoint: Importing the rules from the file works.
bitter-ability-32190
05/04/2022, 4:21 PMSo switching to using
from pants.backend.python.typecheck.mypy.skip_field import rules as skip_rules👎 1
bitter-ability-32190
05/04/2022, 4:23 PMSo ✅ because I have a workaround, but wtf
h
hundreds-father-404
05/04/2022, 4:23 PMare we doing something wrong with packages? very confusing topic
b
bitter-ability-32190
05/04/2022, 4:37 PMAdding an
__init__.pypantsh
hundreds-father-404
05/04/2022, 4:38 PMhm but then i think it breaks testutil package
b
bitter-ability-32190
05/04/2022, 4:38 PM🙈
h
hundreds-father-404
05/04/2022, 4:39 PMProbably worth filing an issue so that we can track this problem
✅ 1
b
bitter-ability-32190
05/04/2022, 4:40 PMWhat's really curious is that it doesn't error for
subsystem👀 1
bitter-ability-32190
05/04/2022, 4:44 PMbitter-ability-32190
05/04/2022, 4:49 PMLess curious, the reason it doesn't complain about
subsytemsubsystemsubsystem5 Views