Is there a convention for where rules related to a subsystem should go? I've seen them at a top-level rules.py file, or in util_rules, or in the subsystem itself. In my example, it's relating to an ExternalTool, that another tool (Subsystem) relies upon

i usually put them in the subsystem file itself if the functionality is related

golang kinda puts some of these in the subsystem file or util_rules, as appropriate. Terraform has this in a tool.py Docker also kinda does both

black/subsystem.py

for example

Oh, I remember why I inferred this. It was a while ago related to whether a Subsystem needed a

rules

method, or whether that was AH! I remember: https://github.com/pantsbuild/pants/issues/14181 This made me think that Subsystems had to be handled separately

ah yeah, rip bad docs

Feel like we need some custom pylint pants rules or something 🙂