https://pantsbuild.org/ logo
Join Slack
Powered by
I have a `node_module` plugin in my code base for ...
# plugins
b
I have a 
node_module
plugin in my code base for building documentation, and before upgrading from pants 1.26 to pants 1.30, we would execute a 
pants run
on the node module however since upgrading to pants 1.30, I get an error that pants run goal only work with python_binary targets. Is there a way to get pants to use the run goal for a node module target under pants 1.30?
h
Huh, that is surprising and probably a bug
So that is a custom plugin of yours?
Not the v1 node plugin (I just know that existed, I have no memory of what it did)?
b
I don't believe it's custom. The definition in the BUILD file is pretty small, but it pulls in a docker file, json files, then defines that it should use npm as the package manager.
I tried re-running with engine v1, and it doesn't die like v2 does, but it still doesn't produce the output I would've expected or log that the node_module was run
h
So yeah that sounds like the standard node plugin
That should still run on the v1 engine. The difference in 1.30 is that it should run Python stuff in the v2 engine
v1 is kinda in the prehistory now, but if you can put together a small example repo that demonstrates this I'm happy to take a look
4 Views
Open in Slack
PreviousNext
Powered by