I'm about to start creating PRs to add pants-plugins to the StackStorm repo, based what I wrote in my PoC repo. I'm wondering if I should reorganize slightly before I make those PRs: So, how do you like to organize your pants-plugins? In the pants repo, all of the custom plugins are consolidated in an

internal_plugins

python module. https://github.com/pantsbuild/pants/tree/main/pants-plugins But, in my StackStorm+pants PoC repo, I separated each plugin into a separate module: https://github.com/st2sandbox/st2/tree/pants/pants-plugins Are there other conventions people have used for their plugins? What are the benefits of one approach vs another?

I use one-directory N-modules. I like the organization and helps remove a specific plugin, as I try very hard to upstream everything I can (in case I get hit by a bus)

Do you call it

internal_plugins

too?

Also, helps me organizae my plugins with the same structure as the Pants repo, which... do as the Romans do...

so, pants has:

//pants-plugins/internal_plugins/<plugin>

But I did:

//pants-plugins/<plugin>

It sounds like you did:

//pants-plugins/wo_<plugin>

right?

Yup! I suspect Pants uses

internal_plugins

because in-and-of-itself it has external plugins 😛

Some of my plugins are very specific to the StackStorm repo, so I'm thinking they should be under

internal_plugins

. And then for the probably-upstreamable plugins (or at least, applicable to more than just StackStorm), I could use something like

upstreamable_plugins

as a parent module.

I think you've entered the realm of "what Jacob Floyd thinks is right" 🙂

lol