So I m jankily calling `Get FmtResult BlackRequest BlackRequ Pants #plugins

So I'm jankily calling `Get(FmtResult, BlackReques...

ambitious-actor-36781

12/12/2022, 1:39 AM

So I'm jankily calling

Get(FmtResult, BlackRequest, BlackRequest(...))

to format the output of my codgen (because reasons) But every time I request the codegen'd code it re-formats the files. And I can't work out for the life of me, which part of the Black rules are preventing it from being cached?

fast-nail-55400

12/12/2022, 1:57 AM

can you share the actual invocation and what you do with the resulting

Digest

bitter-ability-32190

12/12/2022, 2:03 AM

(also you can omit the middle

BlackRequest

😉 the parser recognizes

Get(Result Request(...))

ambitious-actor-36781

12/12/2022, 2:15 AM

oh, maybe it is being cached, it's also caching standard output and displaying that multiple times

ambitious-actor-36781

12/12/2022, 2:27 AM

basically I am doing.

Copy code

result = await Get(ProcessResult, PexProcess(generator_pex.pex, args....)
snapshot = await Get(Snapshot, Digest, result.output_digest)
formatted = await Get(FmtResult, BlackRequest(snapshot=snapshot, field_sets[
  BlackFieldSet(address=target.address, source=PythonSourceField(raw_value=output[1, address=target.address),
  interpreter_constraints=interpreter_constraints)
  for output in output_files]
))

ambitious-actor-36781

12/12/2022, 2:34 AM

ahhh there it is.

FmtResult.cacheable

returns False

bitter-ability-32190

12/12/2022, 2:37 AM

We have a ticket about that. Kinda. Basically it's the only way today to force the output to rerender

bitter-ability-32190

12/12/2022, 2:37 AM

I don't quite agree with the rerendering in the first place, so 👀

4 Views

Open in Slack

Previous Next