before I raise a PR to extend our docs, just to co...
# pluginsf
fresh-cat-90827
12/29/2022, 5:14 PMbefore I raise a PR to extend our docs, just to confirm - I've just noticed that one cannot have options in the plugins which have their name starting with a word that represents an existing goal, as Pants thinks you are adding flags in that goal's scope 🧵
fresh-cat-90827
12/29/2022, 5:14 PMWith
Copy code
run_bar = BoolOption(
default=False,
help="Run bar.",
) Copy code
$ ./pants dummy --run-bar myapp:
Unknown flag --bar on run scope
Did you mean --args?
Use `./pants help run` to get help.
[ERROR] Unknown flags --bar on scope run
$ ./pants dummy --dummy-run-bar myapp:
[INFO] Completed.--check-foob
bitter-ability-32190
12/29/2022, 5:15 PMI think we need better namespacing and scoping of thing in Pants IMHO
bitter-ability-32190
12/29/2022, 5:15 PMThis particular problem will likely persist though 😛
f
fresh-cat-90827
12/29/2022, 5:16 PMalrighty then, raising a PR then 😛
h
happy-kitchen-89482
12/29/2022, 5:52 PMThat is correct, but I would love to fix it
happy-kitchen-89482
12/29/2022, 5:53 PMbecause you can introduce a custom goal name and break existing options
f
fresh-cat-90827
12/29/2022, 8:14 PMbecause you can introduce a custom goal name and break existing optionsoh that's a great point. I've added an issue to track and raised a PR to document this peculiarity. See https://github.com/pantsbuild/pants/pull/17899 and https://github.com/pantsbuild/pants/issues/17900
4 Views