Hi, I forked the Pants repo and added ruff integration, I’m curious if this is something the Pants team would be interested in. I only have 1 failing unit test which checks the skip-ruff option, I couldn’t get it working yet. I would appreciate if anyone can help me with that. Here is the draft PR: https://github.com/pantsbuild/pants/pull/17945

I enabled CI runs for the PR.

I very very very very much want ruff support in Pants, so yes. Please let us know how to help 😀

Thanks for the interest! You can see my comment for the failing test. I couldn’t get the

--ruff-skip

argument to work yet. I’ll take a look into it once I have more free time.

I'll take a look Monday. I'm sure it's something simple 😀

Do we still need to call

ruff.skip

in the main rules somewhere? Or is that handled by the infra now?

That's usually handled by the opt-in partition rule, if you use that

@rule(desc="Fix with ruff", level=LogLevel.DEBUG)
async def ruff_fix(request: RuffRequest.Batch, ruff: Ruff) -> FmtResult:
    ruff_pex_get = Get(
        VenvPex,
        PexRequest,
        ruff.to_pex_request(interpreter_constraints=request.partition_metadata),
    )

?

That's the runner rule, not the partitioner rule. By this point we know we're running the tool

Oops, missed the inheritence:

class RuffRequest(FixTargetsRequest):
    field_set_type = RuffFieldSet
    tool_subsystem = Ruff
    partitioner_type = PartitionerType.DEFAULT_SINGLE_PARTITION


@rule(desc="Fix with ruff", level=LogLevel.DEBUG)
async def ruff_fix(request: RuffRequest.Batch, ruff: Ruff) -> FmtResult:
    ruff_pex_get = Get(
        VenvPex,
        PexRequest,
        ruff.to_pex_request(interpreter_constraints=request.partition_metadata),
    )

So, does FixTargetsRequest handle the skip functionality?

The DEFAULT_SINGLE_PARTITION rule should, yes

Thank you for contributing this @agreeable-microphone-98219!

I think I did in a GitHub issue already. He was for it, but hasn't had to do any breaking changes and this would be one, so warrants more thinking

Thanks for approving the PR @bitter-ability-32190! Please lmk when we can merge this. I want to adopt this at the company I’m working for.

is this ready to merge? would love to see this in pants soon 👀

I got CI kicked

@bitter-ability-32190 Any idea how I can fix this CI error?

Error: Unable to locate the previous sha: 5a200e8f404e72b8fcc7a74a444cb02d3c3d4c10
459
  Error: You seem to be missing 'fetch-depth: 0' or 'fetch-depth: 2'. See <https://github.com/tj-actions/changed-files#usage>
460
  Error: Process completed with exit code 1.

Gotta pull latest

main

and merge into your branch

ok I'll rebase and push again

To save CI time we fetch up to some arbitrary depth. If you drift too far we can't fetch correctly.