OK, master is `1.5.0rc0` which I didn't expect. As...
# announce
e
OK, master is
1.5.0rc0
which I didn't expect. As I re-read the https://www.pantsbuild.org/release_strategy.html and recall in general, only
x.y.z.devN
should be on master and I would have expected
1.5.0rc0
to be off on the
1.5.x
branch. Adding to my confusion is the fact the
1.5.x
branch exists on origin and it says:
Copy code
$ git log --stat -1 upstream/1.5.x
commit b5943c122b799f9edb2b5c1b6b021ca705cdf825 (upstream/1.5.x)
Author: Yi Cheng <wisechengyi@gmail.com>
Date:   Thu Mar 15 10:11:01 2018 -0700

    Bump version to 1.5.0rc1

 src/python/pants/VERSION | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
@wide-energy-11069 I'll wait to sync with you on what I should be doing wrt a master dev release and the split state of the 1.5.x rcs.
w
I think rc0 being on master makes sense. It marks where stable branch starts
there’s probably room for improvement in terms of the version bump procedure on stable branches
e
I don't disagree about including the rc0 commit on master, its just not clear from the release docs this is how to do it. I'll whip up an amendment to those docs to make it crystal clear.
👍 1
w
it's documented on https://www.pantsbuild.org/release.html#1-prepare-release ... but should be on the Strategy page as well, probably.
yes: rc0 is supposed to be on master