https://pantsbuild.org/ logo
Join Slack
Powered by
i merged <https://github.com/pantsbuild/pants/pull...
# announce
a
i merged https://github.com/pantsbuild/pants/pull/6278 just now, and i am near to a solution for https://github.com/pantsbuild/pants/issues/6394 (i think), so i'm going to fix that before making 1.9.0rc2
h
Was 6394 a regression from Py3 changes?
a
not from py3 changes as far as i can tell, john's comments are pretty clear. i don't know what precisely triggered this regression but once i fix it i might, and if it's py3 i'll let you know for sure
h
Okay, thanks! I’m trying to land https://github.com/pantsbuild/pants/pull/6372 atm, will significantly improve our ability to detect Py3 regressions
a
this is awesome! i left a comment that you can 100% ignore
h
Yay thanks for the review! Also I don’t have write access to merge, so will need help with that once we feel ready
Alternatively to fixing in a followup PR, would you be comfortable if I push that cosmetic change but we ignore CI because it’s purely cosmetic?
We can also re-run CI if preferred. This isn’t immediately blocking anything
a
the way i have always seen @witty-crayon-22786 handle this is to make cosmetic changes in a followup if necessary instead of going through CI again
(my comment was about a cosmetic change on this PR, for context)
imo don't worry about this comment i just wanted to bring it up at some point
and we will be able to get to it later
h
That’s fine by me. I am planning on fixing 
test_build_graph
non-determinism this week, so can include in that
a
great! although I would probably do any non-code (style) change in a separate PR from any real changes
that is just the refrain i've heard
👌 1
by the way, if i had to guess, i would think the march 17 commit from benjy which makes everything a list in the 
fingerprint()
method would be what caused the 
--binaries-path-by-id
regression, that and the (assumed) fact that nobody overrides that in 
pants.ini
caused it to take this long
python 2 json.dumps flatly lies and says it coerces keys to strings
so i bring that up just because i doubt py 3 edits caused this
👍 1
2 Views
Open in Slack
PreviousNext
Powered by