the second option is the most appealing to me, lik...
# announcew
witty-crayon-22786
10/16/2018, 7:42 PMthe second option is the most appealing to me, likely because i haven't thought about what it would take to correctly identify the sources that would need to be included
witty-crayon-22786
10/16/2018, 7:50 PMi think that this might look like introspecting the python path to identify the relevant sources to include. guessing that that is not easy to do transitively.
witty-crayon-22786
10/16/2018, 8:00 PMoh, hm. that module has no transitive deps
witty-crayon-22786
10/16/2018, 8:00 PMthat makes this more appealing i think. it would look like introspecting all sources in that module and then dumping them into a pex
witty-crayon-22786
10/16/2018, 8:00 PM Copy code
$ ./pants dependencies contrib/python/src/python/pants/contrib/python/checks/checker:: | sort
3rdparty/python:future
3rdparty/python:pycodestyle
3rdparty/python:pyflakes
3rdparty/python:requirements.txt
3rdparty/python:six
contrib/python/src/python/pants/contrib/python/checks/checker:bin
contrib/python/src/python/pants/contrib/python/checks/checker:checker
future==0.16.0
pycodestyle==2.4.0
pyflakes==2.0.0
six<2,>=1.9.0witty-crayon-22786
10/16/2018, 8:05 PMand 3rdparty deps.
witty-crayon-22786
10/16/2018, 8:06 PMbut also, i suppose that this is potentially more challenging to maintain long term... if you wanted to break the checker binary up into more modules, you'd need to load all of them and their 3rdparty deps manually.
2 Views