as evil as it would be, i might go ahead and land ...
# announcew
witty-crayon-22786
10/31/2018, 4:43 PMas evil as it would be, i might go ahead and land the PR and see whether it repros on master
e
enough-analyst-54434
10/31/2018, 4:44 PMIt does not ring any bells off the top. Staring a bit though at what this might be.
enough-analyst-54434
10/31/2018, 5:20 PMReproduces nicely locally though
enough-analyst-54434
10/31/2018, 5:20 PMIt would be cool to fix. I'll dig here a bit
enough-analyst-54434
10/31/2018, 5:38 PMsetUpClass and tearDownClass are not running - digging as to why
enough-analyst-54434
10/31/2018, 5:52 PMOK - in the category of how did this ever work. I'll send a fix PR against master, but it's a test bug apparently in place since day 1.
enough-analyst-54434
10/31/2018, 5:52 PM1 word change 😕
enough-analyst-54434
10/31/2018, 6:53 PMOK - took me a while to understand why things worked on master w/o fix, but now understood: https://github.com/pantsbuild/pants/pull/6707
w
witty-crayon-22786
10/31/2018, 6:58 PMawesome, thank you so much for diving in there
e
enough-analyst-54434
10/31/2018, 6:59 PMYou're welcome. Stupid mistake(s). The using a dist with real version has been a problem in the past and should know better by now.
w
witty-crayon-22786
10/31/2018, 7:00 PMi'll let you merge that, and then go straight in with the notes change afterward.
e
enough-analyst-54434
10/31/2018, 7:00 PMK
w
witty-crayon-22786
10/31/2018, 7:00 PMi probably need to cherry-pick it to 1.11.x, so might recut them to include it.
e
enough-analyst-54434
10/31/2018, 7:01 PMOK - labelled for cherrypick