Uuuuuuugh I am looking forward to `make_target` go...
# announce
a
Uuuuuuugh I am looking forward to
make_target
going away…
a
going away in favor of? i have used it maybe once in a PR that's gotten merged but can't immediately see what the issue is looking at the method
a
What
make_target
does is constructs a target hoping that its arguments are correct.
Unfortunately, the
sources
arg (and a few others) are in real code 100% of the time set by the engine to a more complex value than people ever pass to
make_target
, which means that those tests are not actually representative of real code
The replacement is to add your target’s definition to a BUILD file (using
add_to_build_file
) and then request that the engine parses out the target (using
target
)