I'm releaser today, anyone got anything they want to get in before I cut the dev release?

If we could get https://github.com/pantsbuild/pants/pull/7235 in before that’d be great. We can wait if you think that’s too rushed

i can review it first

Thanks! Think John is offline most of today but he also held my hand most of the time while I was working on it and gave a quick review this morning

i think it probably would be considered "too rushed" quote unquote but also (1) not everyone is going to be paged in enough to really deeply review it anyway without waiting i think much longer (2) if the release fails because of it, then just unpick it (3) doing a release is a good validation that it works (?)

Yes to 2 and 3. We can have followup PRs also. If it’s any consolation, I’m also very confident in this PR now. Learned a lot about how ABIs and our release works. I think the only review comments would be style things and questions

it is a known flake, restarting

Thank you!

i would move pretty much all of https://github.com/pantsbuild/pants/pull/7235#issuecomment-470985253 into the

Solution

section, the bulleted list is pretty useful

I’m shadowing for next two hours and then can respond! Maybe do followup PR, or else we can wait for next week dev release

(i was thinking a followup)

Please feel free to merge and update PR description how you recommend! I can’t be on phone much next two hours