<@U0AR45336>: have you validated that that fixes t...
# announcew
witty-crayon-22786
05/14/2019, 7:17 PM@salmon-summer-38098: have you validated that that fixes twine?
s
salmon-summer-38098
05/14/2019, 7:18 PMi can confirm it doesnt fix it. so I am bisecting the release notes to get to the line that causes it 🙂
w
witty-crayon-22786
05/14/2019, 7:19 PMif you extract the METADATA file from the wheel, you can look at the line number in context
witty-crayon-22786
05/14/2019, 7:19 PMsee above re: which file
s
salmon-summer-38098
05/14/2019, 7:19 PMi did
w
witty-crayon-22786
05/14/2019, 7:19 PMhm. so what is on line 1287?
s
salmon-summer-38098
05/14/2019, 7:20 PMit point to a line thats always been in the release notes - i dont see anything wrong with that line
w
witty-crayon-22786
05/14/2019, 7:20 PM@salmon-summer-38098: did you remove the header from the file first?
witty-crayon-22786
05/14/2019, 7:20 PMi think that the line number is after taking the other metadata off the top of the METADATA file
witty-crayon-22786
05/14/2019, 7:21 PMi suspect that pypi got more strict ... since the last release. because i hit something like this during the pex release too: https://github.com/pantsbuild/pex/commit/bafa4bb483cb54f60ca4a45615fef37898817c7a
witty-crayon-22786
05/14/2019, 7:21 PM(needed to delete something very old)
s
salmon-summer-38098
05/14/2019, 7:22 PMoh
salmon-summer-38098
05/14/2019, 7:22 PMi think i see it, “\n” 😱
w
witty-crayon-22786
05/14/2019, 7:22 PMthat context might have been relevant, sorry. i think i assumed that this was somehow fallout from master being broken
s
salmon-summer-38098
05/14/2019, 7:27 PMfairly certain, its complaining about this line number:
Copy code
* Properly render \n in exceptions with Py3 (#7073)
`PR #7073 <https://github.com/pantsbuild/pants/pull/7073>`_w
witty-crayon-22786
05/14/2019, 7:31 PMif twine likes it after removal, then I think that you are good.
s
salmon-summer-38098
05/14/2019, 7:36 PMwe are past that error now,
Copy code
$ twine check dist/deploy/wheels/pantsbuild.pants/e0aec1480f1282f0c28a353f6c9caa565b77863d/1.17.0.dev0+gite0aec148/pantsbuild.pants.contrib.avro-1.17.0.dev0+gite0aec148-py27.py36.py37-none-any.whl
Checking distribution dist/deploy/wheels/pantsbuild.pants/e0aec1480f1282f0c28a353f6c9caa565b77863d/1.17.0.dev0+gite0aec148/pantsbuild.pants.contrib.avro-1.17.0.dev0+gite0aec148-py27.py36.py37-none-any.whl: warning: `long_description_content_type` missing. defaulting to `text/x-rst`.
Failed
The project's long_description has invalid markup which will not be rendered on PyPI. The following syntax errors were detected:
line 6: Warning: Duplicate explicit target name: "here".salmon-summer-38098
05/14/2019, 7:36 PMI will just keep iterating until success
salmon-summer-38098
05/14/2019, 7:38 PMdoesnt like the ‘here’ in `The latest documentation can be found `here <http://pantsbuild.org/>`_.` lol
salmon-summer-38098
05/14/2019, 7:45 PM Copy code
$ twine check dist/deploy/wheels/pantsbuild.pants/e0aec1480f1282f0c28a353f6c9caa565b77863d/1.17.0.dev0+gite0aec148/pantsbuild.pants.contrib.avro-1.17.0.dev0+gite0aec148-py27.py36.py37-none-any.whl
Checking distribution dist/deploy/wheels/pantsbuild.pants/e0aec1480f1282f0c28a353f6c9caa565b77863d/1.17.0.dev0+gite0aec148/pantsbuild.pants.contrib.avro-1.17.0.dev0+gite0aec148-py27.py36.py37-none-any.whl: warning: `long_description_content_type` missing. defaulting to `text/x-rst`.
Passedw
witty-crayon-22786
05/14/2019, 7:45 PMYay!
s
salmon-summer-38098
05/14/2019, 7:50 PMhttps://github.com/pantsbuild/pants/pull/7727 - whenever you have a moment, thanks 🙂
2 Views