https://pantsbuild.org/ logo
Join Slack
Powered by
Do people have strong feelings on whether V2 rewri...
# announce
a
Do people have strong feelings on whether V2 rewrites of things sit in “new features” or “refactoring/improvements” in release notes?
I’ll tag @red-balloon-89377 as probably the only person awake and not away 😛
r
I’d say refactorings/improvements
as long as they are functionally identicall
on the basis of “if this were any other performance speedup, it would definitely go under refactorings/improvements”
and if htey are functionally equivalent, it’s just a perf speedup
a
Thanks!
h
I think it depends on the rewrite. I’d say V2 isort is a new feature. We didn’t remove V1 and the interface is different here for how to activate it and that you have to specify the config files. It also implements lint whereas V1 does not
Whereas porting 
list
was refactor because nothing changed for users
a
But it’s also not a feature we expect people to use, probably until it replaces the v1 version, right?
fmt-v2
is effectively a pants-internal place we can store some code (and experiment with it) until we get around to doing the replacement
We happen to expose it to people, but we really hope they don’t actually use it in ways they care about, because it will go away some time…
h
Yes, that is true
I would hate for us to lose agility for example with the V2 ports if we started treating things as API public
Benjy mentioned that we will probably need to do the V2 python pipeline replacement all at once
a
I think we’ll want both versions to exist behind a flag for a while…
👍 1
s/want/need/
h
Sure, but I think switching the entire pipeline over, behind a flag, makes more sense than trying to do so one task/rule at a time.
a
Yeah, I think the general approach of “We can write some v2 stuff that gets synchronously called from a v1 task” is a reasonable middleground sometimes, but mostly we’ll be talking about whole pipelines :)
Open in Slack
PreviousNext
Powered by