Hello, we’ve never successfully released `pantsbui...
# announce
h
Hello, we’ve never successfully released
pantsbuild.pants.testutil
to PyPI and
pantsbuild.pants.testinfra
has not been updated since Nov 3 (we introduced
testutil
Nov 6). We are correctly building both wheels and in
release.sh
I confirmed that the wheels are properly included in the deploy wheel dir right before we call
active_twine
. I think this is an issue with Twine and PyPI? Perhaps we need to register the wheels with PyPI?
@wide-energy-11069 did you see anything about
pantsbuild.pants.testutil
or
pantsbuild.pants.testinfra
during the most recent release?
w
looks like it hasn’t been there after 1.23 https://pypi.org/project/pantsbuild.pants.testinfra/#history
h
Yes, that’s correct. We introduced
pantsbuild.pants.testutil
in between 1.23.0.dev0 and 1.23.0.dev1
w
https://pypi.org/search/?q=pantsbuild doesn’t show anything on testutil either
h
Yes, that’s never been released apparently 😕 even though we do build the wheels successfully.
w
Would the new package need a bit of manual setup on pypi to start with?
h
That’s what I’m suspecting
w
@enough-analyst-54434 would you know if a manual configuration is required for the first publish?
h
or @happy-kitchen-89482 (recently developed the awslambda contrib wheel)
e
None is, no.
It needs setup in our release script though.
Used to be in bash, think this moved to .py?
h
I did that. I added the wheel to
packages.py
and also added a new
pkg_testutil_install_test
test to
release.sh
, which I confirmed runs and works
e
Ok, I'll take a look.
h
I do vaguely remember there being something I had to do to create the pypi package... Cannot recall what though.
e
Should not be - no. Should only be post-facto add other maintainers so subsequent publishes work by others.
h
Thanks. FYI I used this diff and ./build-support/bin/release.sh to confirm that we are correctly fetching the wheels right before calling Twine
w
(I can try to publish again with only testutil in the evening)
h
Thank you Yi! This would be both
testutil
and
testinfra
👌 1
e
testutil published fine, turns out was just being aborted before:
Copy code
twine check pantsbuild.pants.testinfra-1.24.0.dev2-py36.py37-none-any.whl
Checking pantsbuild.pants.testinfra-1.24.0.dev2-py36.py37-none-any.whl: FAILED
  `long_description` has syntax errors in markup and would not be rendered on PyPI.
    line 12: Severe: Unexpected section title.

    Master Pre-Releases
    ===================
  warning: `long_description_content_type` missing.  defaulting to `text/x-rst`.
I'll add the check to release.sh and confirm it aborts / fixup release notes. That said, publishing the docsite used to abort on rst rendering errors...
h
Thank you for finding the fix!
w
I see. Thanks!