Hello, @witty-crayon-22786 @red-balloon-89377 @aloof-angle-91616 could any of you please run in Twitter Source

curl -o fix_deprecated_globs_usage.py -L <https://raw.githubusercontent.com/pantsbuild/pants/6816c9a5d3696ca9713528341e3279272c68fc71/build-support/migration-support/fix_deprecated_globs_usage.py> && chmod +x fix_deprecated_globs_usage.py && ./fix_deprecated_globs_usage.py folder1/ folder2/

? I’m wondering if you still get crashes when running the script

will do. thanks.

should i try to do this with the ini -> toml script too?

eventually, yes. but let's hold off on that. lots of other things to focus on, and there is agreement that the config file format changes won't go in this release.

i would prefer to actually code review and test the script while the PR is up instead of much later

yea.

ok we are aligned

but i think Eric is going to hold off on landing those.

ok

Yes I plan to push to land TOML as soon as 1.25.0rc0 goes out

but nobody seems to say that about my changes

Hm, I’m sorry that’s the perception. Generally, I think the standard we aim to follow (but sometimes fail to) is: “Is this change meaningful enough to stand on its own? Yes? Then we can consider landing. Are there low hanging fruit that we can change first to improve this, though? If so, we should probably do that. Are there actual bugs we know of that prevent this feature from working properly? If so, we should probably fix. If it’s a difficult to solve bug, but this still solves something substantial and you plan to follow up with the additional fix, likely fine to land.”

that's correct, but if people have different perceptions of the answers to those questions, then it suddenly becomes much less of a logical consistent rubric