https://pantsbuild.org/ logo
Join Slack
Powered by
oh. semi-yikes... i think it's not just in the tes...
# announce
w
oh. semi-yikes... i think it's not just in the test harness. https://github.com/pantsbuild/pants/pull/8944 renamed some abstract* methods of Target
*not abstract, but: intended for overriding.
still fine to cut the rc. can cherry pick this.
👍 1
h
Okay cool. Waiting on CI. Thanks for checking that
w
i think i can get a fix out for this one.
❤️ 1
h
Should I go ahead with rc0 or wait?
w
go ahead.
well.
it's a "final release blocker"... if we're anticipating finding others, then there is no point waiting
👍 1
if there is a chance that this is the only thing blocking final, then it might be worth waiting
where we are in our validation right now is: clean sandbox except for some unit tests that caught this issue.
👍 1
h
Sgtm. I’d prefer releasing sooner so that we can do things like land 
pants.toml
w
works for me.
cut it.
(but keep in mind that the toml stuff isn't ready to land today anyway...?)
h
Cool 🙂 fwit, Toolchain will upgrade to this RC as its main version so we’ll also have dogfooding there
(but keep in mind that the toml stuff isn’t ready to land today anyway...?)
*I’d prefer releasing sooner so that we can do things like land pants.toml (pending more reviews)
w
👍
hm, poop. my "method override canary" approach from https://github.com/pantsbuild/pants/pull/6061/files doesn't work in python3
...oh. i can call it and check for a non-empty list. derp.
👍 1
...maybe.
ok, yea: confirmed working. i've already burned enough time on this (needed to fix some internal scripts), so i won't add an upstream test.
🕶️
h
That’s fine with me. Thanks
Open in Slack
PreviousNext
Powered by