https://pantsbuild.org/ logo
Join Slack
Powered by
oh. so... another deprecation related thing to dis...
# announce
w
oh. so... another deprecation related thing to discuss: globs
it is ... challenging... for us to land both the release and the fixing of all of the globs at once
which means that we will have a period where we are on the release with thousands of warnings triggering.
h
Can you use 
--pants-ignore
?
w
these are the globs warnings
sorry, the glob deprecations
h
Yes, 
--pants-ignore
should filter those out, shouldn’t it?
w
these are valid BUILD files
with old school globs in them
h
oh wait that’s the wrong option. I meant the option that allows you to ignore Pants warnings. Sorry
--ignore-pants-warnings
w
wat
i didn't know that that existed.
let me see.
h
@aloof-angle-91616 created it when deprecating 
--quiet
!
w
BUT: we will likely not be the only ones to experience this.
lemme see.
a
they should also be overridable with 
PYTHONWARNINGS='ignore::DeprecationWarning'
but that's currently broken for some reason
h
We should probably update the deprecation warning to mention it. Give people the exact config to use I wish I had remembered to do that in the first place
a
i should have added a test case for those
w
oh wow. that works, and is wonderful.
❤️ 1
💯 1
thank you for adding that Danny.
h
Yay!! Imo, we should update the deprecation warning and cherry-pick that into 1.25.0.x
a
oh hype
w
i can respond to the announcement thread to mention that?
a
might be good to document that or something
h
That would be good too!
a
i can try to do that
w
i thought that this was working, but i realized that it is inconsistent (some of the warnings might have ended up rendered to pantsd' logs or dropped). running without pantsd, i think i'm seeing it reliably.
👍 1
will continue to investigate
lots of churn, but i now fully understand this issue... in pantsd, the warnings filters are not set up correctly. and in the absence of pantsd, i think i failed to set a regex that matched the "start" of the deprecation. will get something out tomorrow to fix both of these.
h
Thanks!
w
@happy-kitchen-89482: do you have time to rubber stamp ^
i think it's the last blocker for 1.25.x, and helps us make it past the globs deprecation more smoothly
thank you sir.
h
👍
2 Views
Open in Slack
PreviousNext
Powered by