In terms of the release situation can I land a cou...
# announcee
early-needle-54791
03/26/2020, 6:37 PMIn terms of the release situation can I land a couple things today?
e
enough-analyst-54434
03/26/2020, 6:44 PMAlways. My release is done anyhow and the next isn't until tomorrow when Eric has release duty.
enough-analyst-54434
03/26/2020, 6:45 PMGenerally releases, dev or stable or rc never block master. Sometimes a releaser might ask for a hold-off on merges just to not miss a changelog entry, but that's about it.
e
early-needle-54791
03/26/2020, 6:57 PM👍 was talking to eric yesterday about merging a couple things which may have needed quick follow ups. Wanted to be sure.
e
enough-analyst-54434
03/26/2020, 7:10 PMAs long as you're not knowingly breaking existing users, its probably OK. But that's the requirement - hopefully - for any PR shipit.
h
hundreds-father-404
03/26/2020, 7:39 PMThe PR in question would have led to a major performance regression until its followup landed, so we didn’t want to land t right before the release.
You’re good to go now :) I’m not sure it even makes sense for me to release tomorrow and I’ll probably wait until Monday
2 Views