looking at the issues caused by the GH action working on a f

Question

looking at the issues caused by the GH action working on a fix

hundreds-father-404 · Answer

Oh hm what issue It worked for Benjy s PR when I added a label

polite-garden-50641 · Answer

it s busted not sure looking into it

polite-garden-50641 · Answer

Screenshot 2020 05 19 17 54 49 png

happy-kitchen-89482 · Answer

Thanks

happy-kitchen-89482 · Answer

` error Can t find action yml action yaml or Dockerfile under home runner work pants pants Did you forget to run actions checkout before running your local action `

hundreds-father-404 · Answer

Will that new PR use the updated config file or it only uses that after a merge edit looks like it uses the updated file That s helpful

polite-garden-50641 · Answer

ok looks like someone with more permissions than myself needs to add a GH token instructions here <https help github com en actions configuring and managing workflows authenticating with the github token>

polite-garden-50641 · Answer

hmm this should work event without I am looking into it

hundreds-father-404 · Answer

Is that saying that the token will only be populated when the author has write access to pantsbuild pants I don t think so because it still fails on Benjy s PR but unclear

polite-garden-50641 · Answer

I am testing stuff on my own repo I ll have answers soon

hundreds-father-404 · Answer

Thanks I pointed out to Benjy that we re allowed to merge on red so master isn t quite broken but certainly appreciated that you re working on this

polite-garden-50641 · Answer

I think the issues is because I submitted the PR

polite-garden-50641 · Answer

I have the same file in my own repo and it works just fine

polite-garden-50641 · Answer

< hundreds father 404> can you copy my changes and submit the PR

polite-garden-50641 · Answer

Screen Shot 2020 05 19 at 6 18 30 PM png

hundreds-father-404 · Answer

Huh Do you think it s enough for me to do you PR that edits things or we need to delete the file and start over

polite-garden-50641 · Answer

I think you can just edit the existing changes

polite-garden-50641 · Answer

basically submit my diff

polite-garden-50641 · Answer

hundreds-father-404 · Answer

Open a new PR with that diff right

polite-garden-50641 · Answer

yes

hundreds-father-404 · Answer

Will do Just finished the release

polite-garden-50641 · Answer

this action works fine on my repo well except for the fact it generates multiple comments but we can address that later

polite-garden-50641 · Answer

polite-garden-50641 · Answer

I can probably improve that will do that soon

polite-garden-50641 · Answer

It makes sense that it doesn t let my PR access the token since I could easily point to an action that I write and upload the token to my server

hundreds-father-404 · Answer

It would probably be most ideal if we could turn it off We don t allow first time contributors to add labels so it s a frustrating UX to get yelled at that they need to do this and they can t I ll add a warning to the contributors guide at <https pants readme io docs contribution flow>

polite-garden-50641 · Answer

so what is going on makes total sense

hundreds-father-404 · Answer

mine failed too confused <https github com pantsbuild pants pull 9832 checks check run id=691214744>

polite-garden-50641 · Answer

ok you should delete this yaml merge it and then submit it yourself if it doesn t work we might need someone with more permissions

hundreds-father-404 · Answer

Possibly Benjy John or Stu They re project owners whereas I m a maintainer

polite-garden-50641 · Answer

ok I think this needs more work I ll revert my original PR for now

polite-garden-50641 · Answer

I ll try to see if there is a more user friendly way to handle this

polite-garden-50641 · Answer

polite-garden-50641 · Answer

I think this should somehow integrate with the GH checks instead of adding a request changes comment also I can probably add some logic to allow contributors to specify labels somehow

polite-garden-50641 · Answer

I think for now you and other committers can manually enforce labeling

hundreds-father-404 · Answer

gt I can probably add some logic to allow contributors to specify labels somehow I think that s a GitHub permissions thing Also I m not certain we want to enforce that the contributor makes that classification

hundreds-father-404 · Answer

Oh I had already put up <https github com pantsbuild pants pull 9832> a little before and pinged people for reviews

witty-crayon-22786 · Answer

ship